Update volcanoplot #6510
Update volcanoplot #6510
Conversation
| <param name="shape_or_facet" value="facet" /> <!-- Testing the facet option --> | ||
| <output name="plot"> | ||
| <assert_contents> | ||
| <has_size value="5007" delta="1000" /> |
There was a problem hiding this comment.
We do have better imaging asserts nowadays, if you want to give it a try.
There was a problem hiding this comment.
you mean compare="image_diff", or are there other undocumented diff options, I think not needed here
There was a problem hiding this comment.
image_diff but there are other image assertions: https://docs.galaxyproject.org/en/latest/dev/schema.html#has-image-center-of-mass
tools/volcanoplot/volcanoplot.xml
Outdated
| <test expect_num_outputs="1"> | ||
| <!-- Ensure input labels and plot options work --> | ||
| <param name="input" ftype="tabular" value="input.tab"/> | ||
| <param name="fdr_col" value="5" /> |
|
ping @paulzierep |
…ols-iuc into update-volcanoplot
|
@bgruening the macros here are not being used in the version, and then this was uploaded to the toolshed without a version change, see https://github.com/galaxyproject/tools-iuc/pull/6510/files#diff-fa1711e49e2c00dd46c9d86d082e9091e5468442a270582b30e3c92cdad4557dR1 |
|
This explains #6620 |
|
Do you see the problem in this PR? |
|
Ah I see. I can release a new version with bump, will this solve your problem? |
|
I would prefer if the 0.0.6 version is reinstated in the toolshed to the last reasonable 0.0.6 revision, I have a bunch of workflows pinned to that. Also this is breaking an IWC workflow. |
|
And then the newer changes are pushed in a different version |
|
@bgruening if the tool XML and macros at 84949ce could be pushed to the toolshed as they are there, then we could have a subsequent PR where we simply flip the version for the newer changes, and "the past will be fixed" :-). |
FOR CONTRIBUTOR: