-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jbrowse2 tool #3997
Draft
abretaud
wants to merge
45
commits into
galaxyproject:main
Choose a base branch
from
abretaud:jbrowse2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Jbrowse2 tool #3997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Love how much can be re-used for this, that's fantastic |
hexylena
reviewed
Feb 21, 2022
tools/jbrowse2/jbrowse2.xml
Outdated
@@ -350,14 +359,15 @@ cp $output.files_path/index.html $output; | |||
|
|||
<!-- TODO genetic code not yet supported in jbrowse2 https://github.com/GMOD/jbrowse-components/issues/1765 --> | |||
|
|||
<!-- TODO show linear view by default? --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Ah good we already support PAF files cannot wait for jb2! synteny, finally! :D |
…nd some track rendering options. Half broken/not finished
(works from internet-less compute nodes + uses a properly frozen version)
bgruening
pushed a commit
to bgruening/tools-iuc
that referenced
this pull request
Mar 30, 2024
test data works now to fix the tests too
bgruening
pushed a commit
to bgruening/tools-iuc
that referenced
this pull request
Mar 30, 2024
Amongst other things, this adds autoopening and adds track options back for JB2 - thanks! Fixed so passes biocontainers testing and various other odds and ends. Adds MAF (awaiting a bcbio PR) PAF and SPARQL not implemented yet. Uses json only - no calls to jbrowse command line tool
bgruening
pushed a commit
to bgruening/tools-iuc
that referenced
this pull request
Mar 30, 2024
rebasing to abreataud galaxyproject#3997 as requested by @hexylena
bgruening
pushed a commit
to bgruening/tools-iuc
that referenced
this pull request
Mar 30, 2024
test data works now to fix the tests too
bgruening
pushed a commit
to bgruening/tools-iuc
that referenced
this pull request
Mar 30, 2024
Amongst other things, this adds autoopening and adds track options back for JB2 - thanks! Fixed so passes biocontainers testing and various other odds and ends. Adds MAF (awaiting a bcbio PR) PAF and SPARQL not implemented yet. Uses json only - no calls to jbrowse command line tool
bgruening
pushed a commit
to bgruening/tools-iuc
that referenced
this pull request
Mar 30, 2024
rebasing to abreataud galaxyproject#3997 as requested by @hexylena
5 tasks
bgruening
pushed a commit
to bgruening/tools-iuc
that referenced
this pull request
May 21, 2024
test data works now to fix the tests too
bgruening
pushed a commit
to bgruening/tools-iuc
that referenced
this pull request
May 21, 2024
Amongst other things, this adds autoopening and adds track options back for JB2 - thanks! Fixed so passes biocontainers testing and various other odds and ends. Adds MAF (awaiting a bcbio PR) PAF and SPARQL not implemented yet. Uses json only - no calls to jbrowse command line tool
bgruening
pushed a commit
to bgruening/tools-iuc
that referenced
this pull request
May 21, 2024
rebasing to abreataud galaxyproject#3997 as requested by @hexylena
bgruening
pushed a commit
to bgruening/tools-iuc
that referenced
this pull request
May 21, 2024
test data works now to fix the tests too
bgruening
pushed a commit
to bgruening/tools-iuc
that referenced
this pull request
May 21, 2024
Amongst other things, this adds autoopening and adds track options back for JB2 - thanks! Fixed so passes biocontainers testing and various other odds and ends. Adds MAF (awaiting a bcbio PR) PAF and SPARQL not implemented yet. Uses json only - no calls to jbrowse command line tool
bgruening
pushed a commit
to bgruening/tools-iuc
that referenced
this pull request
May 21, 2024
rebasing to abreataud galaxyproject#3997 as requested by @hexylena
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FOR CONTRIBUTOR:
This has been standing too long on my hard drive: here's a wrapper for jbrowse2 🎉 🎆 !
Implemented the same way as Jbrowse (though there might be other cool things to do now that it's more embeddable). I mostly copied the jbrowse1 wrapper, and tried to adapt.
It mostly works, but it needs some clean up, there are some options that are still there but don't work yet (or should be removed), some new datatypes to add support to, ....
An interesting thing in jbrowse2 is that many display options can be easily changed from the jbrowse ui (while in jbrowse1 it required tweaking json), which means I'm not sure if we need to (re)implement them all in the form...
Also to test with
planemo server
I had to hack a little as planemo doesn't support byte-range headers. I can probably share my notes if there's interest