Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snpeffdb output to not contain broken symlinks #5648

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Nov 22, 2023

Instead just copy out the actual .bin files.

We have no test coverage for snpeffdb files since those are composite files in disguise, I can test this manually.

Fixes #5647

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

@mvdbeek mvdbeek requested a review from nsoranzo as a code owner November 22, 2023 15:52
Instead just copy out the actual .bin files.
@mvdbeek mvdbeek force-pushed the snpeff_no_broken_symlinks branch from b130df4 to ac5edc4 Compare November 22, 2023 16:28
@mvdbeek
Copy link
Member Author

mvdbeek commented Nov 22, 2023

Tested this manually by downloading https://www.ncbi.nlm.nih.gov/nuccore/KJ660346, building a database for it and then running snpeff on this and input.vcf from the test data folder

@mvdbeek
Copy link
Member Author

mvdbeek commented Nov 22, 2023

linting seems to be false positive for the somewhat odd add_value filter type

@mvdbeek mvdbeek merged commit af2e922 into galaxyproject:main Nov 22, 2023
12 of 14 checks passed
@gxydevbot
Copy link
Collaborator

Attention: deployment skipped!

https://github.com/galaxyproject/tools-iuc/actions/runs/6960487293

@nsoranzo
Copy link
Member

linting seems to be false positive for the somewhat odd add_value filter type

This needs to be uploaded manually to the TS then, as reported by the bot.

@mvdbeek
Copy link
Member Author

mvdbeek commented Nov 22, 2023

I thought we had skipped that rule ?

@mvdbeek
Copy link
Member Author

mvdbeek commented Nov 22, 2023

apparently not: #5650

@mvdbeek
Copy link
Member Author

mvdbeek commented Nov 22, 2023

uploaded manually

@bernt-matthias
Copy link
Contributor

linting seems to be false positive for the somewhat odd add_value filter type

Independent of that (I don't know if this is true since options_filter_attribute is undocumented) I think that the options and validator tag are redundant.

Also options_filter_attribute is super inefficient and has been marked deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants