Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCBI datasets: Update macros.xml regarding taxon selection #5803

Merged
merged 7 commits into from
Mar 4, 2024

Conversation

AnnaSyme
Copy link
Contributor

Suggest adding this text to the wrapper to clarify how to select a taxon. (If this is correct?)

FOR CONTRIBUTOR:

  • [- ] - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • [- ] - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

AnnaSyme and others added 2 commits March 1, 2024 10:55
Suggest adding this text to the wrapper to clarify how to select a taxon. (If this is correct?)
@bernt-matthias bernt-matthias changed the title Update macros.xml regarding taxon selection NCBI datasets: Update macros.xml regarding taxon selection Mar 1, 2024
@@ -71,7 +71,7 @@
</xml>

<xml name="taxon_positional">
<param name="taxon_positional" type="text" label="Enter taxon" help="e.g. human, mouse, bos taurus, etc."/>
<param name="taxon_positional" type="text" label="Enter taxon" help="e.g. human, mouse, bos taurus, etc. or use Taxonomy ID from NCBI for greater accuracy, use species-level only not genera or larger taxa"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by accuracy? Probably depends on the question.

I for instance used this tool only to download all the data for larger taxonomic groups. In this context the last part seems to make not so much sense.

The statement about taxids definitely makes sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah right, thanks @bernt-matthias - I thought it was not extracting data beyond the species level. I'm doing another test to see. Perhaps it's a different error, if I narrow it down I will post it as an issue for this tool.

@bgruening
Copy link
Member

I'm not sure what the error means:

https://github.com/galaxyproject/tools-iuc/actions/runs/8107796267

Should I update the tool to the latest version? I fear that many more tests will fail ;)

@AnnaSyme
Copy link
Contributor Author

AnnaSyme commented Mar 1, 2024

I'm not sure what the error means:

https://github.com/galaxyproject/tools-iuc/actions/runs/8107796267

Should I update the tool to the latest version? I fear that many more tests will fail ;)

Hi @bgruening sorry I can't see the error in that link, but I am getting an error that says ```New version of client (16.6.0) available at https://ftp.ncbi.nlm.nih.gov/pub/datasets/command-line/LATEST/linux-amd64/datasets
Error: No genes found that match selection

@bgruening
Copy link
Member

@AnnaSyme
Copy link
Contributor Author

AnnaSyme commented Mar 4, 2024

@AnnaSyme can you look at the bottom of https://github.com/galaxyproject/tools-iuc/actions/runs/8114718425?pr=5803

Sorry @bgruening I read it but I don't understand why it's failing

@bernt-matthias
Copy link
Contributor

Will have a look.

@bgruening bgruening merged commit 1b6341a into galaxyproject:main Mar 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants