Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating tools/dimet from version 0.2.1 to 0.2.2 #5805

Closed
wants to merge 1 commit into from

Conversation

gxydevbot
Copy link
Collaborator

Hello! This is an automated update of the following tool: tools/dimet. I created this PR because I think the tool's main dependency is out of date, i.e. there is a newer version available through conda.

I have updated tools/dimet from version 0.2.1 to 0.2.2.

Project home page: https://github.com/cbib/DIMet/releases

For any comments, queries or criticism about the bot, not related to the tool being updated in this PR, please create an issue here.

@johaGL
Copy link
Contributor

johaGL commented Mar 4, 2024

we are reviewing which is the origin of the 2 tests failure. The new update 0.2.2 has a modification regarding the statistical method "distribution fitting" (a.k.a. disfit). However the failure is associated to the output .tsv file of the t-test.

@bgruening
Copy link
Member

Thanks for looking into it @johaGL

@johaGL
Copy link
Contributor

johaGL commented Mar 4, 2024

Origin of the 2 tests failure: The new update 0.2.2 has a modification regarding the statistical method "distribution fitting" (a.k.a. disfit), and moreover for any output data frame, the rounding has applied to all numeric columns regardless the name (v 0.2.1 used a hard coded list of column names). This resulted in columns "count_nan_samples" to be transformed into float e.g. 0.0 (when being 0 in v 0.2.1). All the output tables are changed. @bdartigues confirmed to me that he will do a new PR with these changes 👍

@bgruening bgruening closed this Mar 4, 2024
@gxydevbot gxydevbot deleted the tools/dimet branch March 11, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants