Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve idr_download to support download of the full hyperstack #6358

Merged
merged 15 commits into from
Sep 26, 2024

Conversation

lldelisle
Copy link
Contributor

FOR CONTRIBUTOR:

  • [X I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

I needed to add a new dependency as pylibtiff does not allow to write hyperstacks.
I used the asserts for images and the image_diff as much as I could.

Copy link
Contributor

@kostrykin kostrykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much thanks, a few comments inside!

tools/idr_download/idr_download_by_ids.py Outdated Show resolved Hide resolved
tools/idr_download/idr_download_by_ids.py Outdated Show resolved Hide resolved
tools/idr_download/idr_download_by_ids.py Show resolved Hide resolved
tools/idr_download/idr_download_by_ids.py Show resolved Hide resolved
tools/idr_download/idr_download_by_ids.py Outdated Show resolved Hide resolved
tools/idr_download/idr_download_by_ids.py Outdated Show resolved Hide resolved
tools/idr_download/idr_download_by_ids.py Outdated Show resolved Hide resolved
tools/idr_download/idr_download_by_ids.py Outdated Show resolved Hide resolved
tools/idr_download/idr_download_by_ids.xml Outdated Show resolved Hide resolved
tools/idr_download/idr_download_by_ids.xml Outdated Show resolved Hide resolved
@lldelisle
Copy link
Contributor Author

Thank you so much @kostrykin for the careful review. I think we improved the python script a lot for further development.

@bgruening bgruening merged commit a9a143b into galaxyproject:main Sep 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants