-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure correct output formats of seqtk_seq and seqtk_mergefa in all cases #6393
Conversation
- Restricted input formats to only FASTA and compressed FASTA files (.fasta, .fasta.gz). Removed support for FASTQ files. - Updated the tool description and help section to accurately reflect that the tool only merges FASTA files. - Improved the tool's clarity by ensuring it is used for its intended purpose: merging FASTA files only.
Update seqtk_mergefa.xml
"Tool merges FASTA/Q files into a FASTA output and considers the quality threshold for FASTQ files when merging." 1. Clarified the -m option to handle ambiguous bases and conflicts (e.g., N and other IUPAC codes). 2. Improved help documentation with clearer examples and explanations. 3. Refined input parameter labels for better clarity and consistency.
edited echo command line back to #echo
You need to bump the wrapper version. Maybe just this single one and don't change the macros one. In addition, I think the fasta output of the tool would likely have to be If you have the time, you could also pull in the changes from #6350 and fix the output format there. Very similar issue as yours: the output of that tool should always be fasta or fasta.gz, depending on input compression, but never fastq(.gz). |
seqtk seq actually produces also FASTQ as an output ! |
yes, I realize. What I wanted to say is that the logic for handling output formats will be similar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it look good now? @wm75
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Just a few suggestions.
FOR CONTRIBUTOR:
Adjust output format when using
-A force FASTA output (discard quality)
to FASTA