Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snippy: support --ctgs parameter #6591

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jianzuoyi
Copy link

@jianzuoyi jianzuoyi commented Nov 27, 2024

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

@bernt-matthias bernt-matthias changed the title support --ctgs parameter snippy: support --ctgs parameter Nov 27, 2024
Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case?

@@ -82,6 +87,10 @@
<when value="paired_iv">
<param name="fastq_input_interleaved" type="data" format="fastqsanger,fastqsanger.gz" label="Select fastq dataset" help="Specify dataset with interleaved reads"/>
</when>
<when value="contigs">
<param name="fasta_input" type="data" format="fasta,fa,fna" label="Select fasta dataset" help="Specify dataset with assembled contigs"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Galaxy we always call this fasta:

Suggested change
<param name="fasta_input" type="data" format="fasta,fa,fna" label="Select fasta dataset" help="Specify dataset with assembled contigs"/>
<param name="fasta_input" type="data" format="fasta" label="Select fasta dataset" help="Specify dataset with assembled contigs"/>

Do you know if (gzip) compressed input is supported? If so you could add fasta.gz to the list.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your help. I will add a test case, and check if fasta.gz is supported by snippy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants