Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniprot improvements #785

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

bernt-matthias
Copy link
Collaborator

  • switch from stream to search API (stream only supports small datasets https://www.uniprot.org/help/api_queries)
  • add TSV output (possible columns are derived via a call to the uniprot API :))
  • small wording changes

@bernt-matthias
Copy link
Collaborator Author

Linting error will be fixed by galaxyproject/galaxy#19300

group.fields.forEach(function(field) {
var D = ["accession", "id", "reviewed", "protein_name", "gene_names", "organism_name", "length"];
var selected = D.includes(field.name);
options.push([group.groupName + " - " + field.label, field.name, selected]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge. I can push manually if you like and if we don't want to wait for new packages.

@bernt-matthias bernt-matthias merged commit 91705a9 into galaxyproteomics:master Dec 11, 2024
11 checks passed
@bernt-matthias bernt-matthias deleted the uniprot-search branch December 11, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants