Components/Segment #125
Components/Segment #125
Conversation
palingheorghe
added
Status: In Progress
Type: Enhancement
shubhamkakkar
changed the title
There was a problem hiding this comment.
Hi,
Please don't forget about the design files.
You can find out more about what a Segment is from here: https://developer.apple.com/design/human-interface-guidelines/ios/controls/segmented-controls/
Alin
| } | ||
| } | ||
|
|
||
| Segment.prototypes = { |
There was a problem hiding this comment.
This should be Segment.propTypes
| SafeAreaView, | ||
| TouchableNativeFeedback, | ||
| Dimensions, | ||
| Text, |
There was a problem hiding this comment.
Try using the Text component from Galio
| const { | ||
| Provider: TilesDimensionPropProvider, | ||
| Consumer: TilesDimensionPropConsumer, | ||
| } = React.createContext([]); |
There was a problem hiding this comment.
I don't think using context is right for this component. I'd actually prefer using state memorizing which of the Segment's tab is the active one. Maybe we could try having a dataArray prop which will accept an array of components and then render all of those components with they're own onPress function which the user could also edit.
For example let's say: <Segment dataArray={data} onPress={(option) => {/*do something here*/}}/> and the data array would look something like this: data = [<Text>Option 1</Text>, <Text>Option 2</Text>];
What do you think?
palingheorghe
changed the title
|
Hi @shubhamkakkar are you still working on this? |
No description provided.