fix: add has polyfill for alignment #2814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
|
Size Change: +1.5 kB (0%) Total Size: 1.98 MB
ℹ️ View Unchanged
|
bfintal
requested changes
Aug 7, 2023
There was a problem hiding this comment.
I took the liberty of changing some file/script/class names to better reflect the purpose of the newly introduced script.
I have some remaining suggestions / improvements:
- We can have better names for the new classes that can signify that they are polyfill classes:
stk--height-100➡️stk--height-100-polyfillstk-container--has-child-column-flex➡️stk-container--has-child-column-flex-polyfill
- Bring back the specificity of the original selectors you're trying to polyfill, because if not the styles might not be applied correctly.
You're mainly trying to add a class that would have the same effect as the following selectors. But these 2 sets of selectors have different specificities (you can check here: https://specificity.keegan.st/)
:is(.stk-block-content, .stk-inner-blocks):not(.stk--column-flex):has(> :is(.stk--block-margin-top-auto, .stk--block-margin-bottom-auto))➡️ 3.stk-container:has(> .stk--column-flex)➡️ 2
The new selectors are just:
.stk--height-100➡️ 1.stk-container--has-child-column-flex➡️ 1
That means the styles might get easily overridden by other selectors. You'll need to mimic / bump up the specificity to the same level.
| const modifyCSS = () => { | ||
| const containers = document.querySelectorAll( '.stk-container' ) | ||
| containers.forEach( container => { | ||
| const columnFlex = container.querySelector( '.stk--column-flex' ) |
There was a problem hiding this comment.
Based on the selector we're trying to mimic, we need this to be for the direct descendent
Suggested change
| const columnFlex = container.querySelector( '.stk--column-flex' ) | |
| const columnFlex = container.querySelector( ':scope > .stk--column-flex' ) |
Comment on lines
14
to
15
| } else if ( ! columnFlex && container.classList.contains( 'stk-container--has-child-column-flex' ) ) { | ||
| container.classList.remove( 'stk-container--has-child-column-flex' ) |
bfintal
requested changes
Aug 8, 2023
bfintal
reviewed
Aug 8, 2023
bfintal
deleted the
fix/alignment-browser-compatibility-has-pseudo-selector
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2784, fixes #2704