Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: devicify player-utility items #597

Merged
merged 9 commits into from
Nov 8, 2024

Conversation

chipsams
Copy link
Collaborator

@chipsams chipsams commented Apr 2, 2024

these include the wrench, schematics, wand of symmetry, the "definitely currently causes a dupe bug" recycling hammer, the clipboard, the abacus and the personal assembler, (although i'm not really sure how you could lose it...)

This pull request will be merged when its done, when the following checkboxes are checked and when it passes review.

  • tested and confirmed working
    • bulkrecycle command (tools are NOT mysteriously sublimated! that would be bad!)
    • singleplayer
    • server
    • all test cases
      • all entries can't be destroyed
      • all entries can only be acquired through the device recipe

these include the wrench, schematics, wand of symmetry, the "definitely currently causes a dupe bug" recycling hammer, the clipboard, the abacus and the personal assembler, (although i'm not really sure how you could lose it...)
@Yarden-zamir
Copy link
Member

isn't empty_schematic consumable? If not then I think this pr can go in. The only thing I worry about is players getting stuck without a wrench so consumable entries should not be a thing

@chipsams
Copy link
Collaborator Author

ok, the empty schematic isn't consumable! still need to remove the stonecutter on a stick recipe, though.

@chipsams
Copy link
Collaborator Author

chipsams commented Nov 8, 2024

requires merging.. post haste

@Yarden-zamir Yarden-zamir merged commit 894822b into game-design-driven:main Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants