Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: added loot fix for iron golem #595 #609

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

EngineerSmith
Copy link
Collaborator

@EngineerSmith EngineerSmith commented Oct 13, 2024

This pull request will be merged when its done, when the following checkboxes are checked and when it passes review.

  • - tested and confirmed working
    • - singleplayer
    • - server
    • - all test cases
      • - Pre-existing iron golems drop iron sheets
      • - New iron golems drop iron sheets
      • - Player kills drop iron sheets
      • - Iron golem vs environment drops iron sheets
      • - Drops the correct number of iron sheets avg ~2-4

Solution was suggested in #595, slightly modified to keep the correct number of drops as it was only dropping 1 sheet

@EngineerSmith EngineerSmith merged commit 2c42469 into game-design-driven:main Oct 13, 2024
1 check failed
@EngineerSmith EngineerSmith deleted the iron-golems branch October 13, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant