Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: exclude some devices from bulk recycling #622

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

chipsams
Copy link
Collaborator

@chipsams chipsams commented Nov 22, 2024

it can exclude based on the tag "ptdye:recycle_excluded" and categorically refuses to recycle items with nbt, so that blocks with items inside like drawers cannot have their contents annihilated.

This pull request will be merged when its done, when the following checkboxes are checked and when it passes review.

basic checks

  • feature works in singleplayer
  • feature works in multiplayer (verify no de-sync issues)
  • feature works in existing world

feature specific checks

  • successfully recycles normal devices
  • doesn't recycle tools
  • doesn't recycle drawers with contents
  • does recycle empty drawers

chipsams and others added 2 commits November 22, 2024 15:05
it can exclude based on the tag "ptdye:recycle_excluded" and categorically refuses to recycle items with nbt, so that blocks with items inside like drawers cannot have their contents annihilated.
@Yarden-zamir Yarden-zamir merged commit 1e84ce7 into game-design-driven:main Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants