Rework #1
Open
Rework #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows easier access from the slave sites without a forced dependency on the hostname of the master.
git ls-files -z "$(git rev-parse --show-toplevel)" | xargs --null -I '{}' find '{}' -type f -print0 | xargs --null sed --in-place --regexp-extended 's#git(://github.com)#https\1#g;'
DebOps compliance :)
git ls-files -z "$(git rev-parse --show-toplevel)" | xargs --null -I '{}' find '{}' -type f -print0 | xargs --null sed --in-place --regexp-extended 's#checkmk_server__hostname#checkmk_server__fqdn#g;'
git ls-files -z "$(git rev-parse --show-toplevel)" | xargs --null -I '{}' find '{}' -type f -print0 | xargs --null sed --in-place --regexp-extended 's/\<(checkmk_server)_([^_])/\1__\2/g;'
|
Nice work 👍 The documentation was just the next point I wanted to address. I guess so far there are not so much code changes, so I would prefer this to be merged with |
|
Thanks. Done in debops-contrib#54 |
ganto
force-pushed
the
distributed-rework
branch
from
432e67d to
e51f79f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ganto I missed your development branch and was going to rework the role myself. Now, I would rather propose to merge this into https://github.com/ganto/ansible-checkmk_server/tree/distributed-rework to minimize merge conflicts.
I wanted to work a bit more on the role, update the Apache setup and so on. Is that ok with you when I base my work on https://github.com/ganto/ansible-checkmk_server/tree/distributed-rework? I could also wait a few weeks and base my work on master if you prefer that.
Edit: I guess I will wait a bit to not interfere. Just finished reading debops-contrib#53.
Awesome work btw 👍
Related to: debops-contrib#53