-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Ktlint to 1.1.1 #580
Bump Ktlint to 1.1.1 #580
Conversation
Not sure why this update hasen't been sent by @dependabot automatically, maybe we can use @renovate-bot to replace it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #580 +/- ##
============================================
- Coverage 88.16% 86.66% -1.50%
Complexity 91 91
============================================
Files 17 17
Lines 625 555 -70
Branches 59 59
============================================
- Hits 551 481 -70
Misses 35 35
Partials 39 39 ☔ View full report in Codecov by Sentry. |
The commit itself looks good. Could somebody with matching rights retrigger the job to see if it will run through now. We would be very happy to see a version of ktlint-maven-plugin supporting kltint 1.1.1 in the near future. |
@gantsign any chance to update the plugin? |
It doesn't detect inlined string constants as dependency use.
@Goooler thanks for the PR, sorry for the delay. You can find your fix in version 3.1.1 of this plugin (it may take a few hours for it to be downloadable from Maven Central), |
It would be better to follow the latest ktlint version 1.2.1, and draft a new release. |
Not sure why @dependabot hasn't sent ktlint updates, maybe we can replace it with @renovate-bot. |
https://github.com/pinterest/ktlint/releases/tag/1.1.1
Follow up #574.