Skip to content

Commit

Permalink
Change some declarations IsGroup → IsSemigroup
Browse files Browse the repository at this point in the history
Namely:
* DirectProductOp
* SmallGeneratingSet
* MinimalGeneratingSet

These concepts apply just as well to semigroups as to groups.
Currently, the Semigroups and/or Smallsemi packages have to
declare these separately for IsSemigroup, which then leads to
warnings when further methods are installed with the filter
IsGroup, since they match both the IsGroup and IsSemigroup
declarations.

With this change, the packages will no longer need to make such
declarations for semigroups. In the interim, I will attempt to
update Semigroups and Digraphs so that they only make their
declarations if they are not already declared for IsSemigroup,

e.g. I will check for:

[FLAGS_FILTER(IsSemigroup)] in GET_OPER_FLAGS(SmallGeneratingSet)
  • Loading branch information
wilfwilson authored and fingolfin committed Mar 23, 2021
1 parent 4fa619f commit 32d9caa
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lib/gprd.gd
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
## <#/GAPDoc>
##
DeclareGlobalFunction( "DirectProduct" );
DeclareOperation( "DirectProductOp", [ IsList, IsGroup ] );
DeclareOperation( "DirectProductOp", [ IsList, IsSemigroup ] );

#############################################################################
##
Expand Down
4 changes: 2 additions & 2 deletions lib/grp.gd
Original file line number Diff line number Diff line change
Expand Up @@ -2150,7 +2150,7 @@ DeclareAttribute( "LargestElementGroup", IsGroup );
## </ManSection>
## <#/GAPDoc>
##
DeclareAttribute( "MinimalGeneratingSet", IsGroup );
DeclareAttribute( "MinimalGeneratingSet", IsSemigroup );


#############################################################################
Expand All @@ -2175,7 +2175,7 @@ DeclareAttribute( "MinimalGeneratingSet", IsGroup );
## </ManSection>
## <#/GAPDoc>
##
DeclareAttribute( "SmallGeneratingSet", IsGroup );
DeclareAttribute( "SmallGeneratingSet", IsSemigroup );


#############################################################################
Expand Down

0 comments on commit 32d9caa

Please sign in to comment.