-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DirectProductOfPermGroupsWithMovedPoints helper #4326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps Immutable
should be called on the entries of olds
, in order to have independent lists inside the (mutable) DirectProductInfo
record.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I understand this, this indeed will solve my problem (not only mine I hope)
I think the IsFinite(d1) ca IsFinite(g1) is correct (but irrelevant)
This is basically what DirectProduct does for a set of permutation groups, except that one can override the moved points for each factor. This is useful if one needs to compute "sums of G-sets": If e.g. we have a trivial group acting on 3 points, and a Sym(4), then DirectProduct just gives back the Sym(4). But if we need the result to act on 3+4=7 points, with the Sym(4) acting on points acting on [4..7], then this new helper allows us to do that.
@wilfwilson fixed the tests, thanks |
The test failure in |
@ThomasBreuer I know that @hulpke encountered the same failure while working on his PR #4320, which is why he made a change in that PR (now in 52fa8c9) to increase the work done by this test, in an attempt to make it more robust. |
The same kind of test failure was also encountered in #4332; see #4332 (comment). Let's keep an eye out for this happening again. |
Since this is (as @fingolfin said) a niche feature backend feature, without documentation, I don't think this needs to be mentioned in the release notes. |
This is basically what DirectProduct does for a set of permutation groups,
except that one can override the moved points for each factor. This is useful
if one needs to compute "sums of G-sets": If e.g. we have a trivial group
acting on 3 points, and a Sym(4), then DirectProduct just gives back the
Sym(4). But if we need the result to act on 3+4=7 points, with the Sym(4)
acting on points acting on [4..7], then this new helper allows us to do that.
For now, I left this deliberately undocumented, as it is quite niche.