Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused sparselist code #4336

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Remove unused sparselist code #4336

merged 1 commit into from
Nov 8, 2024

Conversation

fingolfin
Copy link
Member

Is there any point in keeping this around?

@fingolfin fingolfin added do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) kind: discussion discussions, questions, requests for comments, and so on labels Mar 23, 2021
@fingolfin fingolfin mentioned this pull request Mar 23, 2021
Merged
@fingolfin fingolfin removed do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) kind: discussion discussions, questions, requests for comments, and so on labels Dec 31, 2021
@fingolfin fingolfin marked this pull request as ready for review December 31, 2021 01:00
@fingolfin
Copy link
Member Author

No comments in march; I think this can be removed...

@fingolfin fingolfin changed the title Remove unused sparselist code (for debate, DO NOT MERGE) Remove unused sparselist code Aug 3, 2022
@fingolfin fingolfin added topic: library release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Aug 3, 2022
@fingolfin
Copy link
Member Author

The alternative would be to move the code into dev/deleted-code if someone feels that's better shrug

@fingolfin fingolfin added this to the GAP 4.14.0 milestone Nov 7, 2024
ThomasBreuer
ThomasBreuer approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is probably not known to most users/developers, thus there is no problem with removing it.

Apparently there is no read need for sparse lists in the GAP library; what would be the right place for such code, perhaps the datastructures package?

@fingolfin fingolfin merged commit c55ee30 into gap-system:master Nov 8, 2024
33 checks passed
@fingolfin fingolfin deleted the mh/sparselist branch November 8, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasBreuer ThomasBreuer ThomasBreuer approved these changes

@ChrisJefferson ChrisJefferson Awaiting requested review from ChrisJefferson

@wilfwilson wilfwilson Awaiting requested review from wilfwilson

Assignees
No one assigned
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: library
Projects
None yet
Milestone
GAP 4.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fingolfin @ThomasBreuer