meataxe spring cleaning #5836
Open
meataxe spring cleaning #5836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
the
release notes: not needed
Also remove redundant arguments
fingolfin
force-pushed
the
mh/meataxe-tuning
branch
from
d1ec0ac
to
b9c9523
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a spring cleaning for the meataxe code. Best to read this commit by commit I guess.
Initially I wanted to change it to make use of
AddVector,MultVector,PositionNonZero, ... in more places. But in the end this mostly about making the code clearer: untangling and deduplication and what not. So that further refactoring and more serious performance tuning (in the works).Might also be best to not squash-merge this (but rather use rebase or a regular merge), so that in case of regressions one can bisect to the offending commit, making debugging a lot easier.