[GSoC 2020] Python Game API #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikosSiak
force-pushed
the
python-game-api
branch
from
d67b89e
to
f4dcef6
Compare
garbear
force-pushed
the
feature_savestates
branch
from
1fc4006
to
f2a19e0
Compare
NikosSiak
force-pushed
the
python-game-api
branch
from
f4dcef6
to
088b2ef
Compare
Thanks to Zach Morris for providing this awesome add-on.
* game.libretro * game.libretro.2048 * game.libretro.mrboom * game.shader.presets * peripheral.joystick * vfs.libarchive * vfs.rar
…s a little and test addons This is purely for test purposes and to ensure that the addons have been converted. Posted as a temporary request in Kodi to be visible to everyone. When the associated add-ons are through, this request is closed again. Revert "Merge pull request 18403 from lrusak/c++17-revert"
Updates cmake to 3.20.3 Set buildsystem for xcode generated projects to use the legacy build system to stay inline with existing behaviour. Cmake 3.19+ when used with xcode 12+ will try to default to the "new" xcode build system
Build failure in mariadb-connector-c checking how to run the C preprocessor... CMake Error at cmake/ConnectorName.cmake:30 (ENDMACRO): Flow control statements are not properly nested. Call Stack (most recent call first): CMakeLists.txt:434 (INCLUDE) This fix is already upstream in mariadb-connector-c 3.1.13. Patch can be dropped when we bump to a newer version
Warning was:
PeripheralJoystick.cpp(337): warning C4244: 'argument': conversion from 'int' to 'float', possible loss of data
I changed this as the "new" build system didnt play nice, but i later added a commit to default to the legacy system with xcode 12 still. Because of that, roll this back to the "default" working code for the Legacy build system.
…d script wrapper Macros There is a variation in a cmake generated project for using ENV vars in a generated shell script. Handle this for both the new/legacy xcode build systems
…lers Needed for Multitap support for Snes9x cores.
…:GameControllerLayout The value "provides_input" within kodi::addon::GameControllerLayout was not set if class was contructed by default. This sets it now to false as default.
This fixes an IDE error in Eclipse CDT by switching from `typedef` to `using`. Error was: Type 'ADDON::AddonInfoPtr' could not be resolved
garbear
force-pushed
the
feature_savestates
branch
from
f2a19e0
to
4cfc4ba
Compare
NikosSiak
force-pushed
the
python-game-api
branch
from
088b2ef
to
6491727
Compare
NikosSiak
force-pushed
the
python-game-api
branch
2 times, most recently
from
afa00ec
to
05f0c1b
Compare
garbear
reviewed
Nov 9, 2021
garbear
reviewed
Nov 9, 2021
garbear
reviewed
Nov 9, 2021
|
I've created a test build and uploaded to https://github.com/garbear/xbmc/releases. I tested it out and everything looks good for me. Only issue was the login button in the settings taking a while to give user feedback during the network IO. Adding a spinner would be a good idea. My only two comments left about the code are the unused variable and the copyright headers. |
NikosSiak
force-pushed
the
python-game-api
branch
3 times, most recently
from
68a8565
to
31e1c01
Compare
…eters to ScaleImage
Fix name clash and add static-correctness The function name "CreateSavestate()" is used to both allocate and create savestates. Let's separate them.
NikosSiak
force-pushed
the
python-game-api
branch
from
31e1c01
to
546eb97
Compare
garbear
force-pushed
the
feature_savestates
branch
2 times, most recently
from
7cac785
to
4bbc92f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the Python API to support game metadata, like title, developer, publisher and captions (from #120 ).
Motivation and Context
How Has This Been Tested?
I have wrote a small addon that uses the API to update the discord rich presence status displaying what game you are playing and what you are doing in the game at this moment https://github.com/NikosSiak/service.games.discord.richpresence
Screenshots (if appropriate):
Types of change
Checklist: