This repository has been archived by the owner on May 26, 2024. It is now read-only.
Adapt machine readiness probe to node-agent #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gardener node agent does not download kubectl anymore to /opt/bin/kubectl. Therefore, the readiness probe of machines in the local setup should no longer refer to this binary. Fortunately, the node image already comes with kubectl in /usr/bin/kubectl, which works for the readiness probe.
gardener-robot
added
needs/review
|
/lgtm |
gardener-robot
added
reviewed/lgtm
oliver-goetz
approved these changes
Jan 9, 2024
gardener-robot
added
the
status/closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adapt machine readiness probe to node-agent.
Gardener node agent does not download kubectl anymore to /opt/bin/kubectl. Therefore, the readiness probe of machines in the local setup should no longer refer to this binary. Fortunately, the node image already comes with kubectl in /usr/bin/kubectl, which works for the readiness probe.
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
After enabling gardener node agent in the local setup, all machines pods stay non-ready. This does not block creation/deletion of shoot clusters. It is not clear what the effect of it is, but it is safer to just use the correct binary.
Release note: