-
Notifications
You must be signed in to change notification settings - Fork 5
Fixing node creationg flow #4
Fixing node creationg flow #4
Conversation
@preved911 Thank you for your contribution. |
f671100
to
b08b9a3
Compare
Thanks for this PR. Also, I would recommend you to consider to add logic to handle this issue. I have already raised a PR for it. cc: @prashanth26 |
Signed-off-by: Ildar Valiullin <[email protected]>
b08b9a3
to
7c15f71
Compare
So, can somebody merge it? I would rebase my PR from new master head after this. |
@zuzzas - Is the maintainer here. Can you please take a look? |
Yea, I contacted Andrey (@zuzzas) on 19th Jul over slack but didn't get a response. Let me try also over email or some other channel. |
@preved911 You have pull request review with status CHANGES_REQUESTED, please check |
I think we need to add more folks here to the Yandex-maintainer list for others to be able to review and merge it. |
Looking at the contributors of this repo it seems Prashanth (@prashanth26) would be the natural candidate to be added as a maintainer. WDYT ? |
Sounds good to me, I guess @prashanth26 @AxiomSamarth are in the best position to suggest though. |
After discussion with @prashanth26 I added @AxiomSamarth to the @gardener/yandex-provider-maintainers group in order to unblock this PR review. |
/lgtm |
What this PR does / why we need it:
Because right now flow not working: new machine object does not create VM and not join it to cluster.
Which issue(s) this PR fixes:
Fixes #3