Skip to content
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.

Fixing node creationg flow #4

Conversation

preved911
Copy link
Contributor

What this PR does / why we need it:
Because right now flow not working: new machine object does not create VM and not join it to cluster.

Which issue(s) this PR fixes:
Fixes #3

@preved911 preved911 requested a review from a team as a code owner July 5, 2021 21:38
@gardener-robot
Copy link

@preved911 Thank you for your contribution.

@CLAassistant
Copy link

CLAassistant commented Jul 5, 2021

CLA assistant check
All committers have signed the CLA.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 5, 2021
@preved911 preved911 force-pushed the fix/machine_processing_after_create branch 2 times, most recently from f671100 to b08b9a3 Compare July 12, 2021 21:27
@hardikdr
Copy link
Contributor

cc @zuzzas @AxiomSamarth

go.mod Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Jul 29, 2021
@AxiomSamarth
Copy link
Collaborator

AxiomSamarth commented Jul 29, 2021

Thanks for this PR. Also, I would recommend you to consider to add logic to handle this issue. I have already raised a PR for it.

cc: @prashanth26

Signed-off-by: Ildar Valiullin <[email protected]>
@preved911 preved911 force-pushed the fix/machine_processing_after_create branch from b08b9a3 to 7c15f71 Compare July 29, 2021 22:29
@preved911
Copy link
Contributor Author

I have already raised a PR for it.

So, can somebody merge it? I would rebase my PR from new master head after this.

@prashanth26
Copy link

@zuzzas - Is the maintainer here. Can you please take a look?

@ghost
Copy link

ghost commented Jul 30, 2021

Yea, I contacted Andrey (@zuzzas) on 19th Jul over slack but didn't get a response. Let me try also over email or some other channel.

@gardener-robot
Copy link

@preved911 You have pull request review with status CHANGES_REQUESTED, please check

@preved911
Copy link
Contributor Author

Yea, I contacted Andrey (@zuzzas) on 19th Jul over slack but didn't get a response. Let me try also over email or some other channel.

Andrey (@zuzzas) didn't answer? Can we continue without his answer?

@hardikdr
Copy link
Contributor

I think we need to add more folks here to the Yandex-maintainer list for others to be able to review and merge it.
@msohn

@msohn
Copy link
Contributor

msohn commented Aug 26, 2021

Looking at the contributors of this repo it seems Prashanth (@prashanth26) would be the natural candidate to be added as a maintainer.

WDYT ?

@hardikdr
Copy link
Contributor

Sounds good to me, I guess @prashanth26 @AxiomSamarth are in the best position to suggest though.

@msohn
Copy link
Contributor

msohn commented Aug 27, 2021

After discussion with @prashanth26 I added @AxiomSamarth to the @gardener/yandex-provider-maintainers group in order to unblock this PR review.

@AxiomSamarth
Copy link
Collaborator

/lgtm

@AxiomSamarth AxiomSamarth merged commit e073f8d into gardener-attic:master Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/changes Needs (more) changes needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node creationg flow failed
7 participants