Skip to content

Commit

Permalink
Revert "disabled retry of RunOnce on failure to remove createErrorNodes"
Browse files Browse the repository at this point in the history
This reverts commit 7947c71.
  • Loading branch information
himanshu-kun committed Sep 28, 2023
1 parent 664a53b commit 01b3f85
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions cluster-autoscaler/core/static_autoscaler.go
Original file line number Diff line number Diff line change
Expand Up @@ -421,11 +421,10 @@ func (a *StaticAutoscaler) RunOnce(currentTime time.Time) caerrors.AutoscalerErr
return nil
}

// FORK-CHANGE: Removed `skipping of iteration on failure to remove createErrorNodes`, to allow for scale-up.
// Reason: Failure will always be there when machineDeployment is under rolling update as per MCM cloudprovider implementation, but scale-up should still be allowed.
danglingNodes, err := a.deleteCreatedNodesWithErrors()
if err != nil {
klog.Warningf("Failed to remove nodes that were created with errors: %v", err)
klog.Warningf("Failed to remove nodes that were created with errors, skipping iteration: %v", err)
return nil
}
if danglingNodes {
klog.V(0).Infof("Some nodes that failed to create were removed, skipping iteration")
Expand Down

0 comments on commit 01b3f85

Please sign in to comment.