Skip to content

Commit

Permalink
minor doc updates
Browse files Browse the repository at this point in the history
  • Loading branch information
aaronfern committed Nov 24, 2023
1 parent c7e66c9 commit 5edbb80
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion cluster-autoscaler/FAQ.md
Original file line number Diff line number Diff line change
Expand Up @@ -1153,7 +1153,7 @@ Assumption: We assume that the developer executing the below stages wants to syn
1. Change to checked-out `autoscaler` dir and set `upstream` and `user` (fork) targets
1. `git remote add user https://github.com/user/autoscaler`
1. `git remote add upstream https://github.com/kubernetes/autoscaler.git`
1. Execute: `git fetch all`
1. Execute: `git fetch --all`
1. Checkout the `releaseBranch`: `git checkout -b upstream-release-1.x.0 upstream/cluster-autoscaler-release-1.x.0`
1. Hard Reset to the `releaseCommitId`: `git reset --hard releaseCommitId`
1. Check out and pull the primary branch for gardener fork which is not `master`/`main` but is instead named `machine-controller-manager-provider`:
Expand Down
8 changes: 4 additions & 4 deletions cluster-autoscaler/integration/usage.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
(Note the prerequisite will be made less restrictive with time.)

1. No user workload to be deployed other than system-components.
2. 1 worker pool for system components named `sys-comp` with `allowSystemComponents` set to `true` and `min=1`, `max>=2`.
3. Required machine size -> 2 cores CPU, 8Gi memory
4. 2 worker pools are needed namely `one-zone` and `three-zones` respectively with `allowSystemComponents` set to `false`. The 4 machinedeployments/node groups in the cluster should be present, with following `min:max` limits
2. 1 worker pool for system components named `sys-comp` with `systemComponents.allow` set to `true` and `min=1`, `max>=2`.
3. Required machine size -> 2 cores CPU, 8Gi memory (Note: Ensure that all worker groups created for these tests use the same machine type)
4. 2 worker pools are needed namely `one-zone` and `three-zones` respectively with `systemComponents.allow` set to `false`. The 4 machinedeployments/node groups in the cluster should be present, with following `min:max` limits
- machineDeployment1 (`0:2`) [worker:- `one-zone`]
- machineDeployment2 (`1:2`) [worker:- `three-zones`]
- machineDeployment3 (`0:1`) [worker:- `three-zones`]
- machineDeployment4 (`0:1`) [worker:- `three-zones`]
5. Make sure that the names of the worker pools are as mentioned above. It is very important for the integration tests to run properly.
6. Make sure to **disable** calico-typha pods as they interfere with Integration test (especially ones related to scale-down due to under-utilization). Refer this [doc](https://github.com/gardener/gardener-extension-networking-calico/blob/master/docs/usage-as-end-user.md#example-networkingconfig-manifest) to disable it.
6. Make sure to **disable** calico-typha pods as they interfere with Integration test (especially ones related to scale-down due to under-utilization). Refer this [doc](https://github.com/gardener/gardener-extension-networking-calico/blob/master/docs/usage/usage.md#calico-typha) to disable it.

## Cluster Autoscaler integration test suite

Expand Down

0 comments on commit 5edbb80

Please sign in to comment.