Skip to content

Commit

Permalink
Re added a fork change command and updated sync change notes
Browse files Browse the repository at this point in the history
  • Loading branch information
aaronfern committed Jan 26, 2024
1 parent 7bfb2bf commit db5a3ac
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
13 changes: 12 additions & 1 deletion cluster-autoscaler/SYNC-CHANGES/SYNC_CHANGES-1.28.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,14 @@

## Changes made
- See general release notes of 1.28.0: https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.28.0
- New flag added: flag.String(config.SchedulerConfigFileFlag, "", "scheduler-config) allows changing configuration of in-tree scheduler plugins acting on PreFilter and Filter extension points")
- The followign options have been added per node group
```
// ZeroOrMaxNodeScaling means that a node group should be scaled up to maximum size or down to zero nodes all at once instead of one-by-one.
ZeroOrMaxNodeScaling bool
// IgnoreDaemonSetsUtilization sets if daemonsets utilization should be considered during node scale-down
IgnoreDaemonSetsUtilization bool
```

### During merging
- Log message for the `scale up not possible case` was updated and an integration test that depended on it was updated
Expand All @@ -27,4 +35,7 @@
- mcm-provider-azure v0.10.0 -> v0.11.1

### Others
- [Release matrix](../README.md#releases-gardenerautoscaler) of Gardener Autoscaler updated.
- [Release matrix](../README.md#releases-gardenerautoscaler) of Gardener Autoscaler updated.
- The `max-empty-bulk-delete` flag will be deprecated in k8s version 1.29. Please use `max-scale-down-parallelism` instead.
- `parallelDrain` flag will be removed in future releases.
- Parallel node group scale ups are now supported (ref: https://github.com/gardener/autoscaler/issues/268)
3 changes: 2 additions & 1 deletion cluster-autoscaler/core/scaleup/orchestrator/orchestrator.go
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,8 @@ func (o *ScaleUpOrchestrator) filterValidScaleUpNodeGroups(
continue
}
if currentTargetSize >= nodeGroup.MaxSize() {
klog.V(4).Infof("Skipping node group %s - max size reached", nodeGroup.Id())
// FORK-CHANGE: log level changed to 2 for better debugging.
klog.V(2).Infof("Skipping node group %s - max size reached", nodeGroup.Id())
skippedNodeGroups[nodeGroup.Id()] = MaxLimitReachedReason
continue
}
Expand Down

0 comments on commit db5a3ac

Please sign in to comment.