forked from kubernetes/autoscaler
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate Early backoff functionality #253
Merged
rishabh-11
merged 24 commits into
gardener:machine-controller-manager-provider
from
himanshu-kun:early-backoff
Oct 3, 2023
Merged
Activate Early backoff functionality #253
rishabh-11
merged 24 commits into
gardener:machine-controller-manager-provider
from
himanshu-kun:early-backoff
Oct 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himanshu-kun
requested review from
unmarshall,
rishabh-11 and
a team
as code owners
September 27, 2023 11:46
gardener-robot
added
needs/review
Needs review
size/xl
Size of pull request is huge (see gardener-robot robot/bots/size.py)
needs/second-opinion
Needs second review by someone else
labels
Sep 27, 2023
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Sep 27, 2023
gardener-robot-ci-1
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Sep 27, 2023
gardener-robot-ci-2
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Sep 27, 2023
/assign @rishabh-11 |
rishabh-11
requested changes
Sep 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Some minor review comments, the rest looks good.
cluster-autoscaler/cloudprovider/mcm/mcm_cloud_provider_test.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/cloudprovider/mcm/mcm_cloud_provider_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Rishabh Patel <[email protected]>
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Sep 28, 2023
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Sep 28, 2023
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Sep 28, 2023
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 3, 2023
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 3, 2023
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Oct 3, 2023
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Oct 3, 2023
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 3, 2023
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 3, 2023
/lgtm |
gardener-robot
added
reviewed/lgtm
Has approval for merging
needs/changes
Needs (more) changes
and removed
needs/changes
Needs (more) changes
needs/review
Needs review
needs/second-opinion
Needs second review by someone else
reviewed/lgtm
Has approval for merging
labels
Oct 3, 2023
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 3, 2023
unmarshall
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
gardener-robot
added
reviewed/lgtm
Has approval for merging
and removed
needs/changes
Needs (more) changes
labels
Oct 3, 2023
rishabh-11
approved these changes
Oct 3, 2023
rishabh-11
merged commit Oct 3, 2023
da973f4
into
gardener:machine-controller-manager-provider
4 checks passed
gardener-robot
added
the
status/closed
Issue is closed (either delivered or triaged)
label
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
reviewed/lgtm
Has approval for merging
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
size/xl
Size of pull request is huge (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Activates Early backoff for mcm cloud provider
Which issue(s) this PR fixes:
Fixes #154
Special notes for your reviewer:
CORNER_CASE:
Docs:
For now they are added in
FAQ.md
. Will move them to another folder, when refactoring CA docs overall.Test results:
Manual Test Case 1
Nodegrp out-of-quota is scaled-up firstCA senses that node won’t come up due to Resource Exhausted , so marks nodegrp as backoff + removes the scaled up machine
CA tries another zone
First scaled up=
12:32:38
Next scale up after learning=
12:33:10
(in just 30sec !)Manual test case 2
Trying scale-up in `no-avail`Backoff on failure
Trying scale-up in
no-avail2
Backoff on failure
Finally scaling up
avail-z1
Internal
errorRelease note:
Gardener autoscaler now backs-off early from a node-group (i.e. machinedeployment) in case of `ResourceExhausted` error. Refer docs at `https://github.com/gardener/autoscaler/blob/machine-controller-manager-provider/cluster-autoscaler/FAQ.md#when-does-autoscaler-backs-off-early-from-a-node-group` for details.