Remove snapshot_ctx_repository attr from pipeline definition
#276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This attribute will be removed with a future release of cc-utils. Hence, it must be removed from the pipeline definition as well. However, this will have no impact on the current functionality as the `ocm_repository` will be used as default for both "snapshot" and "non-snapshot" component descriptors.
8R0WNI3
requested review from
himanshu-kun,
unmarshall,
rishabh-11 and
a team
as code owners
|
@8R0WNI3 Thank you for your contribution. |
gardener-robot
added
needs/review
gardener-robot-ci-3
added
reviewed/ok-to-test
|
@unmarshall, @rishabh-11, @himanshu-kun You have pull request review open invite, please check |
|
/lgtm thanks, @8R0WNI3! |
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attribute will be removed with a future release of cc-utils. Hence, it must be removed from the pipeline definition as well. However, this will have no impact on the current functionality as the
ocm_repositorywill be used as default for both "snapshot" and "non-snapshot" component descriptors.What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
The second occurrence of
snapshot_ctx_repositoryis just removed and not replaced in this case, because the respective job has a release trait and thus thesnapshot_ctx_repositorywas never used anyway.Release note: