Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove VPA pipeline from mcm-provider branch #285

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Remove VPA pipeline from mcm-provider branch #285

merged 2 commits into from
Jan 16, 2024

Conversation

voelzmo
Copy link
Member

@voelzmo voelzmo commented Jan 10, 2024

What this PR does / why we need it:
We only need the pipeline on the rel-vertical-pod-autoscaler branch, therefore let's remove it from the main branch, which is used for releasing cluster-autoscaler only.

Release note:

NONE

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jan 10, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 10, 2024
rishabh-11
rishabh-11 requested changes Jan 11, 2024
View reviewed changes
Copy link

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove vpa pipeline related files added in the .ci folder and other places?

@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Jan 11, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 11, 2024
@voelzmo voelzmo force-pushed the enh/remove-vpa-pipeline-from-mcm branch from 4117fb3 to 3ab10c9 Compare January 11, 2024 07:42
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 11, 2024
@voelzmo
Copy link
Member Author

voelzmo commented Jan 12, 2024

Can you also remove vpa pipeline related files added in the .ci folder and other places?

done.

@gardener-robot
Copy link

@unmarshall, @himanshu-kun You have pull request review open invite, please check

rishabh-11
rishabh-11 approved these changes Jan 16, 2024
View reviewed changes
Copy link

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Jan 16, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 16, 2024
@rishabh-11 rishabh-11 merged commit 468b367 into gardener:machine-controller-manager-provider Jan 16, 2024
10 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-11 rishabh-11 rishabh-11 approved these changes

@himanshu-kun himanshu-kun Awaiting requested review from himanshu-kun

@unmarshall unmarshall Awaiting requested review from unmarshall unmarshall is a code owner

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@voelzmo @gardener-robot @rishabh-11 @gardener-robot-ci-2 @gardener-robot-ci-3