Upgraded go version in pipeline #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sssash18
requested review from
himanshu-kun,
unmarshall,
rishabh-11 and
a team
as code owners
gardener-robot
added
needs/review
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
gardener-robot-ci-3
added
reviewed/ok-to-test
elankath
approved these changes
Apr 25, 2024
rishabh-11
requested changes
Apr 25, 2024
.ci/pipeline_definitions
Outdated
| @@ -36,9 +36,9 @@ autoscaler: | |||
| dockerfile: './cluster-autoscaler/Dockerfile' | |||
| steps: | |||
| test: | |||
| image: 'golang:1.20.5' | |||
| image: 'golang:1.21.6' | |||
There was a problem hiding this comment.
Can you change it to 1.22.2 instead of 1.21.6? Same in other places
There was a problem hiding this comment.
the go version in CA 1.29 is still 1.21, so not sure if this will work out.
There was a problem hiding this comment.
It should work. The go version cannot be less than the required one. A higher version should be fine.
gardener-robot-ci-2
added
the
reviewed/ok-to-test
sssash18
force-pushed
the
go_version_update
branch
from
95fd994 to
f5612be
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
rishabh-11
merged commit 84ae83e
into
gardener:machine-controller-manager-provider
10 checks passed
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates the go version in pipeline.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: