Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging and monitoring in case we have minimum memory recommendations #322

Conversation

plkokanov
Copy link

What this PR does / why we need it:
This PR re-adds additional logging in case the vpa-recommender provides memory recommendations lower than the minimum from #299. In addition it limits the logging only when the recommendation is done for memory and adds a counter metric when such an event occurs so we can track how many times such recommendations are done for each vpa object.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Add a counter metric which can be used to track how many times lower than minimum memory recommendations have been done by the `vpa-recommender`. The full name of the metric is `vpa_quality_lower_than_min_recommendation_count`.

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Aug 15, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 15, 2024
@plkokanov plkokanov force-pushed the enh/add-additional-logging-and-monitoring branch from 21c23fa to e428611 Compare August 15, 2024 07:51
@plkokanov plkokanov marked this pull request as ready for review August 15, 2024 07:52
@plkokanov plkokanov requested a review from ialidzhikov August 15, 2024 09:25
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 15, 2024
@ialidzhikov ialidzhikov merged commit 2cf2b46 into gardener:rel-vertical-pod-autoscaler Aug 15, 2024
5 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants