Use manual version handling to better indicate fork builds #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plkokanov
requested review from
unmarshall,
rishabh-11 and
a team
as code owners
gardener-robot
added
needs/review
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
ccwienk
approved these changes
Oct 31, 2024
ialidzhikov
merged commit 18cd31c
into
gardener:rel-vertical-pod-autoscaler
5 checks passed
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR changes the version of VPA to
1.2.1-gardener-build.2and disables automatic version handling, so that we can manually bump the build number. E.g. the next version would be1.2.1-gardener-build.3and so on. When updating VPA from the upstream branch the major, minor and patch versions would have to be manually updated, e.g. to 1.3.0-gardener-build.1Sadly, this cannot be handled with the current available API of cc-utils so we will have to maintain the version manually.
This is done so that we can better differentiate between builds of the upstream VPA and builds from our forked branch.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/cc @ccwienk @ialidzhikov @voelzmo
Release note: