Detect Cloud Instance by Region as Fallback #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
kind/api-change
gardener-robot-ci-2
added
reviewed/ok-to-test
kon-angelo
reviewed
May 29, 2024
kon-angelo
reviewed
May 29, 2024
Comment on lines
46
to
50
| if cloudConfiguration == nil { | ||
| cloudConfiguration = &azure.CloudConfiguration{Name: helper.CloudInstanceNameFromRegion(backupBucket.Spec.Region)} | ||
| } | ||
|
|
||
| azCloudConfiguration, err := azureclient.AzureCloudConfigurationFromCloudConfiguration(cloudConfiguration) |
There was a problem hiding this comment.
Can't these functions be grouped up in a single function ? Can we imagine using one but not the other ? Like get either a cloudinstance *string or a region *string
There was a problem hiding this comment.
Unfortunately, there is one case where they are both required. However, I agree that duplicating these lines of code tenfold is not the way to go.
I've tried my hand at refactoring it a bit, but unfortunately there is some inherent ugliness here due to the way the upstream cloud-instance structs are defined. Not sure if I have hit the mark, honestly 🤔
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
AndreasBurger
force-pushed
the
az-instance-by-region
branch
from
86e5548 to
9bd8736
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
AndreasBurger
force-pushed
the
az-instance-by-region
branch
from
9bd8736 to
8a80713
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
AndreasBurger
force-pushed
the
az-instance-by-region
branch
from
8a80713 to
cdc3f6b
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
AndreasBurger
force-pushed
the
az-instance-by-region
branch
from
cdc3f6b to
ec9d4fa
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
|
/test |
|
Testrun: e2e-v7wnl +---------------------+---------------------------+---------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------------+---------+----------+ | bastion-test | bastion-test | Failed | 3m27s | | infrastructure-test | infrastructure-test | Omitted | 0s | | infrastructure-test | infra-flow-test | Omitted | 0s | | infrastructure-test | infra-flow-migration-test | Omitted | 0s | +---------------------+---------------------------+---------+----------+ |
fall back to the AWS-way of doing things if no explicit CloudConfiguration is given. We keep the Configuration for possible future support of arbitrary cloud instances (these would then _have_ to provide a future version of the CloudConfiguration).
terraform is basically deprecated at this point
AndreasBurger
force-pushed
the
az-instance-by-region
branch
from
6e16453 to
ab8ac4f
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
|
/test |
|
Testrun: e2e-s2rfw +---------------------+---------------------------+---------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------------+---------+----------+ | bastion-test | bastion-test | Failed | 2m45s | | infrastructure-test | infrastructure-test | Omitted | 0s | | infrastructure-test | infra-flow-test | Omitted | 0s | | infrastructure-test | infra-flow-migration-test | Omitted | 0s | +---------------------+---------------------------+---------+----------+ |
AndreasBurger
force-pushed
the
az-instance-by-region
branch
from
ab8ac4f to
448cfd2
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
|
/test |
|
Testrun: e2e-f8qzt +---------------------+---------------------------+---------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------------+---------+----------+ | bastion-test | bastion-test | Failed | 6m2s | | infrastructure-test | infrastructure-test | Omitted | 0s | | infrastructure-test | infra-flow-test | Omitted | 0s | | infrastructure-test | infra-flow-migration-test | Omitted | 0s | +---------------------+---------------------------+---------+----------+ |
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
AndreasBurger
force-pushed
the
az-instance-by-region
branch
from
448cfd2 to
273e6ea
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
|
/test |
|
Testrun: e2e-8pd2s +---------------------+---------------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------------+-----------+----------+ | bastion-test | bastion-test | Succeeded | 8m33s | | infrastructure-test | infrastructure-test | Succeeded | 31m9s | | infrastructure-test | infra-flow-test | Succeeded | 30m54s | | infrastructure-test | infra-flow-migration-test | Succeeded | 29m46s | +---------------------+---------------------------+-----------+----------+ |
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area usability
/kind enhancement
/platform azure
What this PR does / why we need it:
With the changes in this PR, the extension will look at the name of the region configured in the shoot to determine the correct cloud instance to connect to iff there is no explicit CloudConfiguration provided.
Release note: