Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a check on provider of the machineclass in the driver methods #17

Merged
merged 1 commit into from
Apr 8, 2021
Merged

add a check on provider of the machineclass in the driver methods #17

merged 1 commit into from
Apr 8, 2021

Conversation

AxiomSamarth
Copy link
Collaborator

@AxiomSamarth AxiomSamarth commented Apr 1, 2021 •
edited
Loading

What this PR does / why we need it:
This PR adds a check to verify that the MachineClass being passed for MachineCreation, Deletion and other driver methods belongs to the relevant cloud provider

Which issue(s) this PR fixes:
Fixes #599

Special notes for your reviewer:

Release note:

NONE

@AxiomSamarth AxiomSamarth requested a review from prashanth26 April 1, 2021 11:20
@AxiomSamarth AxiomSamarth requested review from a team as code owners April 1, 2021 11:20
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Apr 1, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 1, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 1, 2021
@AxiomSamarth AxiomSamarth mentioned this pull request Apr 1, 2021
Closed
2 tasks
@prashanth26
Copy link

Loves this.
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Apr 1, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 1, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 1, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 1, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 1, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 5, 2021
@AxiomSamarth
parent 1ebbe3a
5e3466c 
author Samarth Deyagond <[email protected]> 1617275932 +0530
committer Samarth Deyagond <[email protected]> 1617616841 +0530

add a check on provider of the machineclass in the driver methods
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 5, 2021
@AxiomSamarth AxiomSamarth merged commit 75a1298 into master Apr 8, 2021
@AxiomSamarth AxiomSamarth deleted the provider-check branch April 8, 2021 10:17
@AxiomSamarth AxiomSamarth restored the provider-check branch April 14, 2021 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashanth26 prashanth26 prashanth26 approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some additional checks/code to be added across all out of tree providers
6 participants
@AxiomSamarth @prashanth26 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot