Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci:component:github.com/gardener/machine-controller-manager:v0.50.1->v0.52.0] #112

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

gardener-robot-ci-1
Copy link
Contributor

Release Notes:

Bump `k8s.io/*` deps to `v0.28.2`
The default `machine-safety-orphan-vms-period` has been reduced from 30m to 15m.
Fix for edge case of Node object deletion missed during machine termination.
Change OCI Image Registry from GCR (`eu.gcr.io/gardener-project`) to Artifact-Registry (`europe-docker.pkg.dev/gardener-project/releases`). Users should update their references.
Architecture field added in the nodetemplate. This will allow CA to pickup architecture from machine class and schedule pods on relevant arch nodes.
MCM restart happens properly in integration tests now. This fix will get activated, once this version is vendored in your mcm-provider
machine controller won't reconcile machine on non-spec update events
go-git now removed from dependencies due to CVE's.
fixed IT for seed with k8s >= 1.27 as control cluster 
Removes `node.machine.sapcloud.io/not-managed-by-mcm` annotation from nodes managed by the MCM.
Phase transition diagram for a machine object is added to FAQs

@gardener-robot-ci-1 gardener-robot-ci-1 requested review from a team as code owners January 25, 2024 05:59
@gardener-robot gardener-robot added the needs/review Needs review label Jan 25, 2024
@elankath elankath self-assigned this Jan 25, 2024
@gardener-robot
Copy link

@gardener-robot-ci-1 Thank you for your contribution.

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 25, 2024
@gardener-robot gardener-robot added the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Jan 25, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 25, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 30, 2024
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jan 30, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 30, 2024
@elankath
Copy link
Contributor

elankath commented Jan 30, 2024

Local Integration Test run was finally successful after resolving misc issues. (CICD pipeline is yet available for openstack provider)

- Machine controllers test machine resource creation should not lead to any errors and add 1 more node in target cluster
- Machine controllers test machine resource deletion when machines available should not lead to errors and remove 1 node in target cluster
- Machine controllers test machine resource deletion when machines are not available should keep nodes intact
- Machine controllers test machine deployment resource creation with replicas=3 should not lead to errors and add 3 more nodes to target cluster
- Machine controllers test machine deployment resource scale-up with replicas=6 should not lead to errors and add futher 3 nodes to target cluster
- Machine controllers test machine deployment resource scale-down with replicas=2 should not lead to errors and remove 4 nodes from target cluster
- Machine controllers test machine deployment resource scale-down with replicas=2 should freeze and unfreeze machineset temporarily
- Machine controllers test machine deployment resource updation to v2 machine-class and replicas=4 should upgrade machines and add more nodes to target
- Machine controllers test machine deployment resource deletion When there are machine deployment(s) available in control cluster should not lead to errors and list only initial nodes
- Machine controllers test orphaned resources when the hyperscaler resources are queried should have been deleted

Ran 10 of 10 Specs in 1066.318 seconds
SUCCESS! -- 10 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 30, 2024
Copy link
Contributor

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Jan 30, 2024
@rishabh-11 rishabh-11 merged commit 147efab into master Jan 30, 2024
6 checks passed
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 30, 2024
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 30, 2024
@rishabh-11 rishabh-11 deleted the ci-qcjmrwtpr branch January 30, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants