Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Kubeconfig dependency for verification of control cluster in IT #869

Merged
merged 6 commits into from
Nov 20, 2023
Merged

Remove Kubeconfig dependency for verification of control cluster in IT #869

merged 6 commits into from
Nov 20, 2023

Conversation

piyuagr
Copy link
Contributor

@piyuagr piyuagr commented Nov 10, 2023 •
edited by rishabh-11
Loading

What this PR does / why we need it:
This PR removes the dependency on kubeconfig for identifying the control cluster as seed and also, updates the integration tests documentation.

Which issue(s) this PR fixes:
Fixes part of #853

Special notes for your reviewer:

Release note:

fixed IT for seed with k8s >= 1.27 as control cluster

@piyuagr piyuagr requested a review from a team as a code owner November 10, 2023 11:25
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Nov 10, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2023
@rishabh-11 rishabh-11 self-assigned this Nov 10, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 10, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 17, 2023
rishabh-11
rishabh-11 requested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please address the comments

pkg/test/integration/common/framework.go Outdated
isControlSeed = os.Getenv("IS_CONTROL_CLUSTER_SEED")

// To detect orphans with this tag
clusterTagSuffix = "integration-test-cluster"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
clusterTagSuffix = "integration-test-cluster"
targetClusterPlaceholder = "integration-test-cluster"

Make it a constant instead of variable

pkg/test/integration/common/framework.go Outdated Show resolved Hide resolved
pkg/test/integration/common/framework.go Outdated Show resolved Hide resolved
pkg/test/integration/common/helpers/cluster.go Show resolved Hide resolved
pkg/test/integration/common/framework.go Outdated Show resolved Hide resolved
pkg/test/integration/common/framework.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Nov 17, 2023
@rishabh-11 rishabh-11 assigned piyuagr and unassigned rishabh-11 Nov 17, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 17, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 17, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 17, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 20, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 20, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 20, 2023
rishabh-11
rishabh-11 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes labels Nov 20, 2023
@gardener-robot gardener-robot removed the needs/review Needs review label Nov 20, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 20, 2023
@rishabh-11 rishabh-11 changed the title Removed the kubeconfig dependencies and updated the integration doc. Remove Kubeconfig dependency for verification of control cluster in IT Nov 20, 2023
@rishabh-11 rishabh-11 merged commit 5067ec8 into gardener:master Nov 20, 2023
8 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 20, 2023
@rishabh-11 rishabh-11 mentioned this pull request Nov 20, 2023
Closed
11 tasks
@piyuagr piyuagr assigned rishabh-11 and unassigned piyuagr Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-11 rishabh-11 rishabh-11 approved these changes

Assignees

@rishabh-11 rishabh-11

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@piyuagr @rishabh-11 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot