Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed old IT code from mcm. #873

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Removed old IT code from mcm. #873

merged 2 commits into from
Nov 28, 2023

Conversation

piyuagr
Copy link
Contributor

@piyuagr piyuagr commented Nov 27, 2023

What this PR does / why we need it:
This PR removes the old IT code from mcm repo.

Which issue(s) this PR fixes:
Fixes #853

Special notes for your reviewer:

Release note:

NONE

@piyuagr piyuagr requested a review from a team as a code owner November 27, 2023 09:20
@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Nov 27, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 27, 2023
himanshu-kun
himanshu-kun approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Nov 27, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 27, 2023
himanshu-kun
himanshu-kun suggested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kindly remove

machine-controller-manager/.ci/test

Line 20 in 627676d

export SKIP_INTEGRATION_TESTS=X

@himanshu-kun himanshu-kun self-assigned this Nov 27, 2023
@piyuagr
Copy link
Contributor Author

piyuagr commented Nov 27, 2023

kindly remove

machine-controller-manager/.ci/test

Line 20 in 627676d

export SKIP_INTEGRATION_TESTS=X

kindly remove

machine-controller-manager/.ci/test

Line 20 in 627676d

export SKIP_INTEGRATION_TESTS=X

Do you also want to remove the if-else statement Line 71-72 Because the check will be of no use and we can directly write "Skipping the Integration tests."

@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Nov 28, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 28, 2023
himanshu-kun
himanshu-kun approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/second-opinion Needs second review by someone else labels Nov 28, 2023
@himanshu-kun himanshu-kun merged commit 1b57e16 into gardener:master Nov 28, 2023
8 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 28, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshu-kun himanshu-kun himanshu-kun approved these changes

Assignees

@himanshu-kun himanshu-kun

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance pipeline setup for IT to adapt to gardener environment changes
6 participants
@piyuagr @himanshu-kun @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot