Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcdctl precalculated argument values are validated before preset. #116

Merged
merged 6 commits into from
Apr 17, 2024
Merged

etcdctl precalculated argument values are validated before preset. #116

merged 6 commits into from
Apr 17, 2024

Conversation

mimiteto
Copy link
Contributor

What this PR does / why we need it:
etcdctl precalculated argument values are validated before preset.
If deemed inappropriate hinting message is printed.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

`etcdctl` precalculated arguments are validated before set. If deemed inappropriate, hint is printed for the operator to set the correct values.

@mimiteto
etcdctl precalculated argument values are validated before preset.
87a874b 
If deemed inapropriate hinting message is printed
@mimiteto mimiteto requested a review from a team as a code owner April 11, 2024 09:07
@gardener-robot gardener-robot added the needs/review Needs review label Apr 11, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 11, 2024
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Apr 11, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 11, 2024
petersutter
petersutter reviewed Apr 11, 2024
View reviewed changes
install_on_demand/.etcdctl Outdated Show resolved Hide resolved
install_on_demand/.etcdctl Outdated Show resolved Hide resolved
install_on_demand/.etcdctl Outdated Show resolved Hide resolved
@petersutter
Copy link
Member

Screenshot 2024-04-11 at 11 26 07
Some suggestions:

  • Texts like Certificate not found in the expected path. should be displayed with warning color
  • The suggestions like You can use --cert=/path/to/file should not display with error color, it's just a hint and should have the info color / no color
  • maybe also print the path where the script was looking for the files

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 11, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 11, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 11, 2024
petersutter
petersutter approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if I like the green color (for info) vs no color, but apart from that

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Apr 11, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 11, 2024
@mimiteto
Copy link
Contributor Author

It is info at the end of the day.
I don't have an opinion here.

@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 16, 2024
@mimiteto mimiteto force-pushed the fix/etcd_corrected_params branch from 744056b to fbc217b Compare April 16, 2024 13:30
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 16, 2024
plkokanov
plkokanov approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@plkokanov plkokanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@petersutter petersutter merged commit 31e7a0c into gardener:master Apr 17, 2024
8 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plkokanov plkokanov plkokanov approved these changes

@petersutter petersutter petersutter approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mimiteto @petersutter @plkokanov @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot