Allow opening device by Serial #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just want to say thanks for this lib, I've found it super useful! |
…ting wide strings
|
This ended up being super important for my local workflow, so I went ahead and implemented it and changed my original issue to a PR. Let me know if you have any feedback or would like any tweaks made before merging. |
|
Let me know if there is anything I can do to help get this ready to merge. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just want to confirm what I've found. It is currently not possible to pass a serial number into HidApi.open, right? I'm not asking for a fix (unless you feel like doing it), but I just want to confirm. It looks like the serial is defined in FFI as an int type, when really it should be a WCHAR pointer. It also looks like the WCHAR implementation currently only supports reading strings not writing them. I have thought about using https://github.com/nthachus/ffi_wide_char, which supports both ways, but that would require reworking all of the string types.