Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace liburdfdom-dev with the ROS package urdfdom #6

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Nov 4, 2024

This ensures that we use the same version on all supported platforms.

Uses gazebo-tooling/gz_vendor#13.

This ensures that we use the same version on all supported platforms

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from caguero November 4, 2024 21:46
@azeey
Copy link
Collaborator Author

azeey commented Nov 5, 2024

The CI job is only failing due to a warning, which we can fix in a follow-up. The build actually succeeded, so I think this is good to go @caguero.

@azeey azeey merged commit b00abe7 into rolling Nov 5, 2024
1 check failed
@azeey azeey deleted the replace_liburdfdom-dev branch November 5, 2024 19:07
@azeey
Copy link
Collaborator Author

azeey commented Nov 5, 2024

@Mergifyio backport jazzy

azeey added a commit that referenced this pull request Nov 5, 2024
This ensures that we use the same version on all supported platforms

Signed-off-by: Addisu Z. Taddese <[email protected]>
azeey added a commit that referenced this pull request Nov 5, 2024
This ensures that we use the same version on all supported platforms

Signed-off-by: Addisu Z. Taddese <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants