Merge branch 'master' into jrivero/test_new_credentials

gazebo-tooling · Nov 22, 2024 · 704062e · 704062e
2 parents 7f121b8 + 96bcff2
commit 704062e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/jenkins-scripts/dsl/brew_release.dsl b/jenkins-scripts/dsl/brew_release.dsl
@@ -135,7 +135,7 @@ bottle_job_builder.with
         preBuildCleanup()
         credentialsBinding {
           // crendetial name needs to be in sync with provision code at infra/osrf-chef repo
-          string('GITHUB_TOKEN', 'osrf-migration-token')
+          string('GITHUB_TOKEN', 'osrfbuild-token')
         }
    }
 

diff --git a/jenkins-scripts/lib/homebrew_bottle_creation.bash b/jenkins-scripts/lib/homebrew_bottle_creation.bash
@@ -83,6 +83,7 @@ brew tap osrf/simulation
 # replace with 'hub -C $(brew --repo osrf/simulation) pr checkout ${ghprbPullId}'
 # after the following hub issue is resolved:
 # https://github.com/github/hub/issues/2612
+# hub requires authentication to operate. GITHUB_TOKEN enviroment variable for example
 pushd $(brew --repo osrf/simulation) && \
   hub pr checkout ${ghprbPullId} && \
   popd