Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for OSRFSourceCreation and tests related #1024

Merged
merged 6 commits into from
Oct 10, 2023

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Oct 6, 2023

Following up #989 and #1008, some fixes and improve of the testing. Each commit is self-contained:

  • Fix PACKAGE_NAME replaced by PACKAGE in previous changes e5b2ebc
  • Change TARBALL_NAME bY S3_FILES_TO_UPLOAD 3602f12
  • Use PROJECT_NAME_TO_COPY_ARTIFACTS instead of hardcoding test job 05afb08
  • Support EXTRA_OSRF_REPO to be passed to OSRFReleasepy 7122876
  • Handle ~ symbols in git tags 0543b68

Do not use TARBALL_NAME anymore and use S3_FILES_TO_UPLOAD instead.
Improve the testing script by listing all possible files passed.

Fix the use of relative path instead the absolute one.

Signed-off-by: Jose Luis Rivero <[email protected]>
The ~ symbol used in prereleases is not supported by git tags. Needs to convert it to a -.
@j-rivero j-rivero force-pushed the jrivero/part1_dsl_gz_source_jobs branch from 43d08ca to 42c47ed Compare October 10, 2023 16:16
Signed-off-by: Jose Luis Rivero <[email protected]>
@j-rivero j-rivero force-pushed the jrivero/part1_dsl_gz_source_jobs branch from 42c47ed to 0215e2b Compare October 10, 2023 16:21
@j-rivero
Copy link
Contributor Author

Tested: Build Status

@j-rivero j-rivero merged commit 5324467 into master Oct 10, 2023
1 check passed
@j-rivero j-rivero deleted the jrivero/part1_dsl_gz_source_jobs branch October 10, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant