-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change abichecker generation to use gz-collection.yaml #1038
Conversation
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
… being active (#1032) Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
fc2bb5f
to
01b6341
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all the abichecker jobs using the gz
prefix now? I see ign_*.xml
files in /tmp/pr_xml_configuration
, so I wasn't sure.
Also, I'm seeing abi jobs for each platform (e.g. gz_sim-abichecker-any_to_any-ubuntu-focal-amd64.xml
,
gz_sim-abichecker-any_to_any-ubuntu-jammy-amd64.xml
). I think we only need one.
Signed-off-by: Jose Luis Rivero <[email protected]>
3ce3bbf
to
dd865de
Compare
Signed-off-by: Jose Luis Rivero <[email protected]>
Mostly libs duplicated from Garden in Harmonic. Signed-off-by: Jose Luis Rivero <[email protected]>
The names are using the lib names defined in the yaml file. Citadel is using the ign- prefix but all others are using the gz- now.
Good catch. To workaround this, I've excluded manually the libs in the yaml file in d996eb9 and added a CI test for it. I would prefer to solve this in a declarative way instead of coding a hidden solver for it. The rest of jobs listed here that runs on different platforms they are supporting different branches should be fine and needed to have them. |
Log is a mix of tabs diffs (introduce quite a lot of noise but the change needed was a bug fix), legitim old jobs change configuration and reports of new jobs present only in the PR. Can not find anything abnormal. |
Looking at the trigger branches, for example in
But the |
Should be fixed by #1040 |
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
95eb32f
to
267a580
Compare
Modify the abichecker job generation to use the new static configuration. Steps done:
Diff from existing gz-physics-abichecker (focal) to the new one (jammy):