-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change release.py to use the new centralized tarball approach #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Helper function to calculate the repository URI from the local path of releasing. Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
This was referenced Oct 28, 2023
nuclearsandwich
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a minor typo all good!
Co-authored-by: Steven! Ragnarök <[email protected]>
scpeters
approved these changes
Nov 2, 2023
Co-authored-by: Steve Peters <[email protected]>
j-rivero
added a commit
that referenced
this pull request
Nov 7, 2023
* Remove all code related to tarball generation * Implement new parameters and logic for calling -source or -debbuidlers when needed * Implement a test script for release.py and use it in Github Actions. --------- Signed-off-by: Jose Luis Rivero <[email protected]> Co-authored-by: Steven! Ragnarök <[email protected]> Co-authored-by: Steve Peters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR changes the release.py logic to be able to use the new generation of tarball that happens on Jenkins instead of using the dev local machines. See the linked docs update for a general usage and data flow overview gazebosim/docs#403
No changes in releasing workflow and the release.py call: Note that the tag of the project code to be built still happens in the local dev system so the workflow is the same than now: go to the source code you want to build and run
release.py
with the same arguments than now. Instead of calling-debbuilders
there will a chain of actions composedPR is quite long, probably easier to read change by change to understand the logic:
--no-generate-source-file
and clean up nightly generation 7887be0--source-repo-existing-ref
and--source-tarball-uri
. If--source-tarball-uri
:--help
what the new parameters do 8aca8acgz-foo-source
directory as entry point--source-tarball-uri
calls will triggergz-foo-debbuilders
directly since no source code needs to be generated.--bump-only-revision-linux
parameter to need--source-tarball-uri
cbb83e2CI Testing:
1. Change release.py to be use
_RELEASEPY_TEST_RELEASE_REPO
4791392#diff-9f016d3777d731463c2969cd7d16bb014363bee6bf98af9fe7ca66c4392949ad2. See the bash testing in a870d8c#diff-9074386702f4ff2677975dcd91d17dd99887e1e2a886f8234056e4a8ebefbf9b
Manual testing:
Run the whole generation pipeline with the real example of
gz-utils2
version2.2.0~pre3
. Steps were as follow:CMakeLists.txt
cd code/gz-utils
~/code/release-tools/release.py gz-utils2 2.2.0~pre1 <token> --dry-run --upload-to-repo prerelease
to see the gz-source~/code/release-tools/release.py gz-utils2 2.2.0~pre1 <token> --upload-to-repo prerelease
1. The release.py call triggers gz-utils2-source . Which after success, called:
repository_uploader_packages
finish) to call the debbuilders using--source-tarball-uri
that points to the new tarball. The call and output is hidden in the a workspace log for security reasons. . This job will call--debuilders
and the brew bottle builder as it is done until now.