Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outdated-job-runner job list #1050

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

Crola1702
Copy link
Contributor

After #1047, naming on garden, fortress, and citadel changed for Linux

This PR updates the job list for periodic runs

@Crola1702 Crola1702 requested a review from Blast545 October 27, 2023 20:09
@Crola1702 Crola1702 self-assigned this Oct 27, 2023
@Crola1702 Crola1702 requested a review from j-rivero as a code owner October 27, 2023 20:09
Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any way to check this script before merging pull requests changes to it? Or compare it against our internal common.py?

Something to think about once you are back.

@j-rivero
Copy link
Contributor

Side note: it would be great to use the output of the own job generation (see #985) to somehow feed this list. Not for this PR but a nice future work.

@claraberendsen
Copy link
Contributor

Side note: it would be great to use the output of the own job generation (see #985) to somehow feed this list. Not for this PR but a nice future work.

Agreed that it would be nice to connect it to the changes on the dsl jobs. I will add it to our backlog for future work.

@claraberendsen claraberendsen self-requested a review November 1, 2023 15:27
Copy link
Contributor

@claraberendsen claraberendsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM in terms of getting us up to date with the current approach. However for these names I think we should push to have one source of truth that we fetched this information from rather than manually updating each time, given that this affects us a couple of number of times in the year.

@claraberendsen
Copy link
Contributor

@Blast545 feel free to merge this as is for now, and let's add a new tasks on how we can keep this list up-to-date with the changes in the jobs.

@Blast545 Blast545 merged commit 2d79621 into master Nov 1, 2023
1 check passed
@Blast545 Blast545 deleted the Crola1702/update-tracked-jobs-list branch November 1, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants