Avoid duplicate abichecker in Fortress/Harmonic #1126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 65e51f0.
Signed-off-by: Jose Luis Rivero <[email protected]>
Files /tmp/current_xml_configuration/gz_cmake-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_cmake-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_common-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_common-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_common-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_common-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_fuel_tools-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_fuel_tools-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_fuel_tools-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_fuel_tools-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_gui-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_gui-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_gui-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_gui-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_launch-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_launch-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_launch-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_launch-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_math-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_math-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_math-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_math-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_msgs-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_msgs-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_msgs-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_msgs-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_physics-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_physics-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_physics-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_physics-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_plugin-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_plugin-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_plugin-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_plugin-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_rendering-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_rendering-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_rendering-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_rendering-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_sensors-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_sensors-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_sensors-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_sensors-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_sim-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_sim-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_sim-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_sim-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_tools-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_tools-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_transport-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_transport-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_transport-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_transport-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_utils-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/gz_utils-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/gz_utils-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/gz_utils-ci-pr_any-focal-amd64.xml differ
Files /tmp/current_xml_configuration/sdformat-abichecker-any_to_any-ubuntu-focal-amd64.xml and /tmp/pr_xml_configuration/sdformat-abichecker-any_to_any-ubuntu-focal-amd64.xml differ
Files /tmp/current_xml_configuration/sdformat-ci-pr_any-focal-amd64.xml and /tmp/pr_xml_configuration/sdformat-ci-pr_any-focal-amd64.xml differThis is breaking things that are unrelated to the change :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1095
The fact of having two abichecker in the PRs can be workaround by defining a new ci_configuration (
focal_exclude_harmonic_abi_dups) which clones focal for Garden but exclude the libraries also present in Harmonic from having an abichecker.The PR also reverts : "Disable DSL check for duplicate abicheckers (#1099)" so the dsl_check is in place again.