Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use noble on Ionic and __upcoming__ instead of Jammy for PR and daily #1138

Merged
merged 7 commits into from
May 17, 2024
Merged

Use noble on Ionic and __upcoming__ instead of Jammy for PR and daily #1138

merged 7 commits into from
May 17, 2024

Conversation

j-rivero
Copy link
Contributor

Replace #1134.

  • Add a new CI configuration entry called noble_no_pr for Harmonic that adds the daily CI jobs for it without including a PR integration,
  • Move the all Ionic to Noble
  • Move the upcoming libs to Noble

@j-rivero j-rivero mentioned this pull request May 16, 2024
Closed
@j-rivero
Copy link
Contributor Author

Checking the changes. The log generated and committed seems fine changing jammy by noble for the Ionic and upcoming tracked jobs.

PR jobs XML changes:

New noble are created:

/tmp ❯ grep Only in xml_config_content_changed.diff | grep pr_any-
xml_config_content_changed.diff:Only in /tmp/pr_xml_configuration: gz_cmake-ci-pr_any-noble-amd64.xml
xml_config_content_changed.diff:Only in /tmp/pr_xml_configuration: gz_common-ci-pr_any-noble-amd64.xml
xml_config_content_changed.diff:Only in /tmp/pr_xml_configuration: gz_fuel_tools-ci-pr_any-noble-amd64.xml
xml_config_content_changed.diff:Only in /tmp/pr_xml_configuration: gz_gui-ci-pr_any-noble-amd64.xml
xml_config_content_changed.diff:Only in /tmp/pr_xml_configuration: gz_launch-ci-pr_any-noble-amd64.xml
xml_config_content_changed.diff:Only in /tmp/pr_xml_configuration: gz_math-ci-pr_any-noble-amd64.xml
xml_config_content_changed.diff:Only in /tmp/pr_xml_configuration: gz_msgs-ci-pr_any-noble-amd64.xml
xml_config_content_changed.diff:Only in /tmp/pr_xml_configuration: gz_physics-ci-pr_any-noble-amd64.xml
xml_config_content_changed.diff:Only in /tmp/pr_xml_configuration: gz_plugin-ci-pr_any-noble-amd64.xml
xml_config_content_changed.diff:Only in /tmp/pr_xml_configuration: gz_rendering-ci-pr_any-noble-amd64.xml
xml_config_content_changed.diff:Only in /tmp/pr_xml_configuration: gz_sensors-ci-pr_any-noble-amd64.xml
xml_config_content_changed.diff:Only in /tmp/pr_xml_configuration: gz_sim-ci-pr_any-noble-amd64.xml
xml_config_content_changed.diff:Only in /tmp/pr_xml_configuration: gz_tools-ci-pr_any-noble-amd64.xml
xml_config_content_changed.diff:Only in /tmp/pr_xml_configuration: gz_transport-ci-pr_any-noble-amd64.xml
xml_config_content_changed.diff:Only in /tmp/pr_xml_configuration: gz_utils-ci-pr_any-noble-amd64.xml
xml_config_content_changed.diff:Only in /tmp/pr_xml_configuration: sdformat-ci-pr_any-noble-amd64.xml

branches in new PR jobs are fine:

gz_sim-ci-pr_any-noble-amd64.xml-            <spec></spec>
gz_sim-ci-pr_any-noble-amd64.xml-            <cron></cron>
gz_sim-ci-pr_any-noble-amd64.xml:            <whiteListTargetBranches>
gz_sim-ci-pr_any-noble-amd64.xml-                <org.jenkinsci.plugins.ghprb.GhprbBranch>
gz_sim-ci-pr_any-noble-amd64.xml-                    <branch>main</branch>
gz_sim-ci-pr_any-noble-amd64.xml-                </org.jenkinsci.plugins.ghprb.GhprbBranch>
gz_sim-ci-pr_any-noble-amd64.xml:            </whiteListTargetBranches>
gz_sim-ci-pr_any-noble-amd64.xml-            <triggerPhrase>.*(re)?run test(s).*</triggerPhrase>
gz_sim-ci-pr_any-noble-amd64.xml-            <extensions>
--
gz_tools-ci-pr_any-noble-amd64.xml-            <spec></spec>
gz_tools-ci-pr_any-noble-amd64.xml-            <cron></cron>
gz_tools-ci-pr_any-noble-amd64.xml:            <whiteListTargetBranches>
gz_tools-ci-pr_any-noble-amd64.xml-                <org.jenkinsci.plugins.ghprb.GhprbBranch>
gz_tools-ci-pr_any-noble-amd64.xml-                    <branch>gz-tools2</branch>
--
gz_tools-ci-pr_any-noble-amd64.xml-                    <branch>main</branch>
gz_tools-ci-pr_any-noble-amd64.xml-                </org.jenkinsci.plugins.ghprb.GhprbBranch>
gz_tools-ci-pr_any-noble-amd64.xml:            </whiteListTargetBranches>
gz_tools-ci-pr_any-noble-amd64.xml-            <triggerPhrase>.*(re)?run test(s).*</triggerPhrase>
gz_tools-ci-pr_any-noble-amd64.xml-            <extensions>
--
gz_transport-ci-pr_any-noble-amd64.xml-            <spec></spec>
gz_transport-ci-pr_any-noble-amd64.xml-            <cron></cron>
gz_transport-ci-pr_any-noble-amd64.xml:            <whiteListTargetBranches>
gz_transport-ci-pr_any-noble-amd64.xml-                <org.jenkinsci.plugins.ghprb.GhprbBranch>
gz_transport-ci-pr_any-noble-amd64.xml-                    <branch>main</branch>
gz_transport-ci-pr_any-noble-amd64.xml-                </org.jenkinsci.plugins.ghprb.GhprbBranch>
gz_transport-ci-pr_any-noble-amd64.xml:            </whiteListTargetBranches>
gz_transport-ci-pr_any-noble-amd64.xml-            <triggerPhrase>.*(re)?run test(s).*</triggerPhrase>
gz_transport-ci-pr_any-noble-amd64.xml-            <extensions>
....

Collection dashboards are updated fine:

diff -ur -I '.*<id>dashboard_portlet_.*</id>.*' /tmp/current_xml_configuration/gz-__upcoming__.xml /tmp/pr_xml_configuration/gz-__upcoming__.xml
--- /tmp/current_xml_configuration/gz-__upcoming__.xml	2024-05-16 14:26:42.740214839 +0000
+++ /tmp/pr_xml_configuration/gz-__upcoming__.xml	2024-05-16 14:25:19.999658672 +0000
@@ -5,8 +5,8 @@
     <jobNames>
         <comparator class='hudson.util.CaseInsensitiveComparator'></comparator>
         <string>gz_tools-ci-main-homebrew-amd64</string>
-        <string>gz_tools-ci-main-jammy-amd64</string>
-        <string>gz_tools-ci_asan-main-jammy-amd64</string>
+        <string>gz_tools-ci-main-noble-amd64</string>
+        <string>gz_tools-ci_asan-main-noble-amd64</string>
         <string>gz_tools-main-win</string>
         <string>gz_tools3-install-pkg-jammy-amd64</string>
         <string>gz_tools3-install_bottle-homebrew-amd64</string>
diff -ur -I '.*<id>dashboard_portlet_.*</id>.*' /tmp/current_xml_configuration/gz-ionic.xml /tmp/pr_xml_configuration/gz-ionic.xml
--- /tmp/current_xml_configuration/gz-ionic.xml	2024-05-16 14:26:42.664214340 +0000
+++ /tmp/pr_xml_configuration/gz-ionic.xml	2024-05-16 14:25:19.923658073 +0000
@@ -20,98 +20,98 @@
         <string>gz-transport14-debbuilder</string>
         <string>gz-utils3-debbuilder</string>
         <string>gz_cmake-ci-main-homebrew-amd64</string>
-        <string>gz_cmake-ci-main-jammy-amd64</string>
-        <string>gz_cmake-ci_asan-main-jammy-amd64</string>
+        <string>gz_cmake-ci-main-noble-amd64</string>
+        <string>gz_cmake-ci_asan-main-noble-amd64</string>
         <string>gz_cmake-main-win</string>
         <string>gz_cmake4-install-pkg-jammy-amd64</string>
         <string>gz_cmake4-install_bottle-homebrew-amd64</string>
         <string>gz_common-ci-main-homebrew-amd64</string>
-        <string>gz_common-ci-main-jammy-amd64</string>
-        <string>gz_common-ci_asan-main-jammy-amd64</string>
+        <string>gz_common-ci-main-noble-amd64</string>
+        <string>gz_common-ci_asan-main-noble-amd64</string>
         <string>gz_common-main-win</string>
         <string>gz_common6-install-pkg-jammy-amd64</string>
         <string>gz_common6-install_bottle-homebrew-amd64</string>
         <string>gz_fuel_tools-ci-main-homebrew-amd64</string>
-        <string>gz_fuel_tools-ci-main-jammy-amd64</string>
-        <string>gz_fuel_tools-ci_asan-main-jammy-amd64</string>
+        <string>gz_fuel_tools-ci-main-noble-amd64</string>
+        <string>gz_fuel_tools-ci_asan-main-noble-amd64</string>
         <string>gz_fuel_tools-main-win</string>
         <string>gz_fuel_tools10-install-pkg-jammy-amd64</string>
         <string>gz_fuel_tools10-install_bottle-homebrew-amd64</string>
         <string>gz_gui-ci-main-homebrew-amd64</string>
-        <string>gz_gui-ci-main-jammy-amd64</string>
-        <string>gz_gui-ci_asan-main-jammy-amd64</string>
+        <string>gz_gui-ci-main-noble-amd64</string>
+        <string>gz_gui-ci_asan-main-noble-amd64</string>
...

@j-rivero j-rivero merged commit cf3b6de into master May 17, 2024
1 check passed
@j-rivero j-rivero deleted the jrivero/remove_indexes_noble_prs branch May 17, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@j-rivero