Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSRFcredentials class and test for DSL #1212

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

j-rivero
Copy link
Contributor

This PR replaces the test.dsl in #1206 and checks the two main token that are going to be used for the osrfbuild user as discussed in #1206 (comment):

  • OSRFBUILD_GITHUB_TOKEN: for git operations and pull requests
  • OSRFBUILD_JENKINS_TOKEN: for authenticate into the server

The credential class also has an allowOsrfbuildToRunTheBuild that can restrict which projects can be build by the osrfbuild user when making remote calls.

Operations needs to be done in production:

  • Generate a new OSRFBUILD_JENKINS_TOKEN for the osrfbuild user with the id of `
  • Change the type of the OSRFBUILD_GITHUB_TOKEN or generate a new one and set it up as a usernamePassword with the ID github-osrfbuild-credentials

@j-rivero j-rivero force-pushed the jrivero/test_new_credentials branch from 5108320 to 1d200b5 Compare November 22, 2024 14:08
@j-rivero
Copy link
Contributor Author

j-rivero commented Nov 22, 2024

Working for both Jenkins API and Github token in Build Status

@j-rivero
Copy link
Contributor Author

Going to merge to unblock other credential migration.

@j-rivero j-rivero merged commit fb391d1 into master Nov 22, 2024
1 check passed
@j-rivero j-rivero deleted the jrivero/test_new_credentials branch November 22, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant