Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore gz-jetty major version #1227

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

Crola1702
Copy link
Contributor

Gz-jetty major version is not being ignored, producing an error in jetty-nightly-scheduler:

+ python3 ./scripts/release.py gz-jetty1 nightly --auth osrfbuild:**** --release-repo-branch main --nightly-src-branch main --upload-to-repo nightly
Downloading releasing info for gz-jetty1
Error running command (git ls-remote -q --exit-code https://github.com/gazebo-release/gz-jetty1-release).
stdout: 
stderr: fatal: could not read Username for 'https://github.com/': No such device or address

@Crola1702 Crola1702 self-assigned this Dec 17, 2024
@Crola1702 Crola1702 requested a review from j-rivero as a code owner December 17, 2024 15:59
@j-rivero
Copy link
Contributor

Looking into the changes produced by the GitHub action:

Only in /tmp/pr_xml_configuration: gz-jetty-debbuilder.xml
Only in /tmp/pr_xml_configuration: gz-jetty-source.xml
diff -ur -I '.*<id>dashboard_portlet_.*</id>.*' /tmp/current_xml_configuration/gz-jetty.xml /tmp/pr_xml_configuration/gz-jetty.xml
--- /tmp/current_xml_configuration/gz-jetty.xml	2024-12-17 16:02:22.723454992 +0000
+++ /tmp/pr_xml_configuration/gz-jetty.xml	2024-12-17 16:00:52.538323133 +0000
@@ -28,8 +28,8 @@
         <string>gz_gui-ci_asan-gz-gui9-noble-amd64</string>
         <string>gz_gui9-install-pkg-noble-amd64</string>
         <string>gz_gui9-install_bottle-homebrew-amd64</string>
-        <string>gz_jetty1-install-pkg-noble-amd64</string>
-        <string>gz_jetty1-install_bottle-homebrew-amd64</string>
+        <string>gz_jetty-install-pkg-noble-amd64</string>
+        <string>gz_jetty-install_bottle-homebrew-amd64</string>
         <string>gz_launch-8-win</string>
         <string>gz_launch-ci-gz-launch8-homebrew-amd64</string>
         <string>gz_launch-ci-gz-launch8-noble-amd64</string>
Only in /tmp/current_xml_configuration: gz-jetty1-debbuilder.xml
Only in /tmp/current_xml_configuration: gz-jetty1-source.xml
Only in /tmp/pr_xml_configuration: gz_jetty-install_bottle-homebrew-amd64.xml
Only in /tmp/current_xml_configuration: gz_jetty1-install-pkg-noble-amd64.xml
Only in /tmp/current_xml_configuration: gz_jetty1-install_bottle-homebrew-amd64.xml
diff -ur -I '.*<id>dashboard_portlet_.*</id>.*' /tmp/current_xml_configuration/ignition-jetty-nightly-scheduler.xml /tmp/pr_xml_configuration/ignition-jetty-nightly-scheduler.xml
--- /tmp/current_xml_configuration/ignition-jetty-nightly-scheduler.xml	2024-12-17 16:02:26.615495385 +0000
+++ /tmp/pr_xml_configuration/ignition-jetty-nightly-scheduler.xml	2024-12-17 16:00:56.370374578 +0000
@@ -17,7 +17,7 @@
                 </hudson.model.BooleanParameterDefinition>
                 <hudson.model.StringParameterDefinition>
                     <name>NIGHTLY_PACKAGES</name>
-                    <defaultValue>gz-cmake4 gz-tools2 gz-utils3 gz-math8 gz-plugin3 gz-common6 gz-msgs11 gz-rendering9 sdformat15 gz-fuel-tools10 gz-transport14 gz-gui9 gz-sensors9 gz-physics8 gz-sim9 gz-launch8 gz-jetty1</defaultValue>
+                    <defaultValue>gz-cmake4 gz-tools2 gz-utils3 gz-math8 gz-plugin3 gz-common6 gz-msgs11 gz-rendering9 sdformat15 gz-fuel-tools10 gz-transport14 gz-gui9 gz-sensors9 gz-physics8 gz-sim9 gz-launch8 gz-jetty</defaultValue>
                     <description>space separated list of packages to build</description>
                 </hudson.model.StringParameterDefinition>
                 <hudson.model.BooleanParameterDefinition>

This last chunk should fix the problem. Thanks @Crola1702 !

@j-rivero j-rivero merged commit ba1938b into master Dec 17, 2024
@j-rivero j-rivero deleted the Crola1702/fix-jetty-major-version branch December 17, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants