Improve static library support

cmake/IgnUtils.cmake

@@ -1416,6 +1416,10 @@ macro(_ign_add_library_or_component)
     set(install_include_dir
       "${IGN_INCLUDE_INSTALL_DIR_FULL}/${include_dir}")
 
+    if (NOT BUILD_SHARED_LIBS)
+      target_compile_definitions(${lib_name} PUBLIC ${export_base}_STATIC_DEFINE)
+    endif()
+
     # Configure the installation of the automatically generated file.
     install(
       FILES "${implementation_file_name}"

examples/CMakeLists.txt

@@ -13,8 +13,10 @@ set(example_directories
   no_ignition_prefix
   prerelease
   core_nodep
+  core_nodep_static
   core_child
   core_child_private
+  core_static_child
   comp_deps
   )
 if (NOT CMAKE_GENERATOR MATCHES "Visual Studio")
@@ -36,12 +38,18 @@ foreach(example ${example_directories})
   elseif (${example} STREQUAL "core_nodep")
     set(example_tarball_name ignition-core_no_deps-0.1.0.tar.bz2)
     set(run_codecheck true)
+  elseif (${example} STREQUAL "core_nodep_static")
+    set(example_tarball_name ignition-core_no_deps_static-0.1.0.tar.bz2)
+    set(run_codecheck true)
   elseif (${example} STREQUAL "core_child")
     set(example_tarball_name ignition-core_child-0.1.0.tar.bz2)
     set(run_codecheck true)
   elseif (${example} STREQUAL "core_child_private")
     set(example_tarball_name ignition-core_child_private-0.1.0.tar.bz2)
     set(run_codecheck true)
+  elseif (${example} STREQUAL "core_static_child")
+    set(example_tarball_name ignition-core_static_child-0.1.0.tar.bz2)
+    set(run_codecheck true)
   elseif (${example} STREQUAL "comp_deps")
     set(example_tarball_name ignition-component_deps-0.1.0.tar.bz2)
   elseif (${example} STREQUAL "use_component_depsA")
@@ -153,6 +161,7 @@ endforeach()
 foreach (build_type ${build_types})
   add_dependencies(core_child_${build_type} core_nodep_${build_type})
   add_dependencies(core_child_private_${build_type} core_nodep_${build_type})
+  add_dependencies(core_static_child_${build_type} core_nodep_static_${build_type})
   if (TARGET use_component_depsA_${build_type})
     add_dependencies(use_component_depsA_${build_type} comp_deps_${build_type})
   endif()

examples/core_nodep_static/CMakeLists.txt

@@ -0,0 +1,8 @@
+cmake_minimum_required(VERSION 3.10.2 FATAL_ERROR)
+project(ignition-core_no_deps_static VERSION 0.1.0)
+find_package(ignition-cmake2 REQUIRED)
+ign_configure_project()
+OPTION(BUILD_SHARED_LIBS OFF)
+ign_configure_build(QUIT_IF_BUILD_ERRORS)
+ign_create_packages()
+ign_create_docs()

examples/core_nodep_static/README.md

@@ -0,0 +1,14 @@
+# core\_nodep\_static example
+
+This package sets the `BUILD_SHARED_LIBS` cmake variable to `OFF`,
+ensuring that a static library will be created.
+The package has no dependencies.
+
+To build:
+
+~~~
+mkdir build
+cd build
+cmake ..
+make
+~~~

examples/core_nodep_static/src/AlmostEmpty.cc

@@ -0,0 +1,29 @@
+/*
+ * Copyright (C) 2021 Open Source Robotics Foundation
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+*/
+
+#include <ignition/core_no_deps_static/Export.hh>
+
+namespace ignition
+{
+  namespace core_no_deps
+  {
+    class IGNITION_CORE_NO_DEPS_STATIC_VISIBLE AlmostEmpty
+    {
+      public: AlmostEmpty() = default;
+    };
+  }
+}

examples/core_nodep_static/src/CMakeLists.txt

@@ -0,0 +1,3 @@
+ign_get_libsources_and_unittests(sources gtest_sources)
+ign_create_core_library(SOURCES ${sources} CXX_STANDARD 11)
+ign_build_tests(TYPE UNIT SOURCES ${gtest_sources})

examples/core_static_child/CMakeLists.txt

@@ -0,0 +1,8 @@
+cmake_minimum_required(VERSION 3.10.2 FATAL_ERROR)
+project(ignition-core_static_child VERSION 0.1.0)
+find_package(ignition-cmake2 REQUIRED)
+ign_configure_project()
+ign_find_package(ignition-core_no_deps_static REQUIRED)
+ign_configure_build(QUIT_IF_BUILD_ERRORS)
+ign_create_packages()
+ign_create_docs(TAGFILES "${IGNITION-CORE_NO_DEPS_STATIC_DOXYGEN_TAGFILE} = ${IGNITION-CORE_NO_DEPS_STATIC_API_URL}")

examples/core_static_child/README.md

@@ -0,0 +1,15 @@
+# core\_static\_child example
+
+This package links against that static library provided by
+the `core_no_deps_static` package.
+
+To build, ensure that `core_no_deps_static` has been installed somewhere
+in your `CMAKE_PREFIX_PATH` and then run:
+
+~~~
+mkdir build
+cd build
+cmake ..
+make
+~~~
+

examples/core_static_child/src/CMakeLists.txt

@@ -0,0 +1,6 @@
+ign_get_libsources_and_unittests(sources gtest_sources)
+ign_create_core_library(SOURCES ${sources} CXX_STANDARD 11)
+target_link_libraries(${PROJECT_LIBRARY_TARGET_NAME}
+  PUBLIC
+    ignition-core_no_deps_static::ignition-core_no_deps_static)
+ign_build_tests(TYPE UNIT SOURCES ${gtest_sources})

examples/core_static_child/src/empty.cc

@@ -0,0 +1,17 @@
+/*
+ * Copyright (C) 2021 Open Source Robotics Foundation
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+*/
+